You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/04/18 02:12:31 UTC
[GitHub] [kylin] allenma commented on a change in pull request #605:
KYLIN-3942 Support multi-level json event in backend
allenma commented on a change in pull request #605: KYLIN-3942 Support multi-level json event in backend
URL: https://github.com/apache/kylin/pull/605#discussion_r276496451
##########
File path: stream-core/src/main/java/org/apache/kylin/stream/core/source/IStreamingMessageParser.java
##########
@@ -21,5 +21,5 @@
import org.apache.kylin.stream.core.model.StreamingMessage;
public interface IStreamingMessageParser<T> {
- StreamingMessage parse(T sourceMessage);
+ StreamingMessage parse(T sourceMessage, int partition, long offset);
Review comment:
It is better not change the interface
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services