You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2016/04/19 16:52:46 UTC
Review Request 46389: Using a public repo definition file is not
reporting correct versions on blueprint install
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46389/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
Repository: ambari
Description
-------
When using a public VDF, the version is not precisely known like a local VDF is. The version comes in as, say, 2.5.0.0 (instead of 2.5.0.0-1111 eg). Installation commands will take the repository_version_id as a pass-through in the structured out of the command. When it returns in the response, the StackVersionListener can then update the correct record in the case of a mismatch.
Also corrected a version display issue for dry_run and XML validation when invalid by-hand repos are uploaded that don't specify XSD.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/script/script.py 31d7b2a
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 31635ed
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 8e50da6
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 58bab59
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a85f939
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java b5b12d8
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionAdvertisedEvent.java 11ca72b
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 2a627dd
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java 685a07c
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 709781e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java 3637cab
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java 784830d
ambari-server/src/test/java/org/apache/ambari/server/view/ViewDirectoryWatcherTest.java d9f8919
ambari-server/src/test/python/custom_actions/TestInstallPackages.py e62978a
Diff: https://reviews.apache.org/r/46389/diff/
Testing
-------
Manual. Automated pending.
Thanks,
Nate Cole
Re: Review Request 46389: Using a public repo definition file is not
reporting correct versions on blueprint install
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46389/#review129556
-----------------------------------------------------------
Ship it!
Ship It!
ambari-server/src/test/java/org/apache/ambari/server/view/ViewDirectoryWatcherTest.java (line 114)
<https://reviews.apache.org/r/46389/#comment192989>
Nice.
- Jonathan Hurley
On April 19, 2016, 11:39 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46389/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 11:39 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-15977
> https://issues.apache.org/jira/browse/AMBARI-15977
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When using a public VDF, the version is not precisely known like a local VDF is. The version comes in as, say, 2.5.0.0 (instead of 2.5.0.0-1111 eg). Installation commands will take the repository_version_id as a pass-through in the structured out of the command. When it returns in the response, the StackVersionListener can then update the correct record in the case of a mismatch.
>
> Also corrected a version display issue for dry_run and XML validation when invalid by-hand repos are uploaded that don't specify XSD.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/script/script.py 31d7b2a
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 31635ed
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 8e50da6
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 58bab59
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a85f939
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java b5b12d8
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionAdvertisedEvent.java 11ca72b
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 2a627dd
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java 685a07c
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 709781e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java 3637cab
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java 784830d
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewDirectoryWatcherTest.java d9f8919
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py e62978a
>
> Diff: https://reviews.apache.org/r/46389/diff/
>
>
> Testing
> -------
>
> Manual. Automated:
>
>
> Tests run: 4222, Failures: 0, Errors: 0, Skipped: 32
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:56.039s
> [INFO] Finished at: Tue Apr 19 11:33:21 EDT 2016
> [INFO] Final Memory: 34M/596M
> [INFO] ------------------------------------------------------------------------
>
>
> ----------------------------------------------------------------------
> Total run:964
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 46389: Using a public repo definition file is not
reporting correct versions on blueprint install
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46389/
-----------------------------------------------------------
(Updated April 19, 2016, 11:39 a.m.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
Bugs: AMBARI-15977
https://issues.apache.org/jira/browse/AMBARI-15977
Repository: ambari
Description
-------
When using a public VDF, the version is not precisely known like a local VDF is. The version comes in as, say, 2.5.0.0 (instead of 2.5.0.0-1111 eg). Installation commands will take the repository_version_id as a pass-through in the structured out of the command. When it returns in the response, the StackVersionListener can then update the correct record in the case of a mismatch.
Also corrected a version display issue for dry_run and XML validation when invalid by-hand repos are uploaded that don't specify XSD.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/script/script.py 31d7b2a
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 31635ed
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 8e50da6
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 58bab59
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a85f939
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java b5b12d8
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionAdvertisedEvent.java 11ca72b
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 2a627dd
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java 685a07c
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 709781e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java 3637cab
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java 784830d
ambari-server/src/test/java/org/apache/ambari/server/view/ViewDirectoryWatcherTest.java d9f8919
ambari-server/src/test/python/custom_actions/TestInstallPackages.py e62978a
Diff: https://reviews.apache.org/r/46389/diff/
Testing (updated)
-------
Manual. Automated:
Tests run: 4222, Failures: 0, Errors: 0, Skipped: 32
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:56.039s
[INFO] Finished at: Tue Apr 19 11:33:21 EDT 2016
[INFO] Final Memory: 34M/596M
[INFO] ------------------------------------------------------------------------
----------------------------------------------------------------------
Total run:964
Total errors:0
Total failures:0
OK
Thanks,
Nate Cole
Re: Review Request 46389: Using a public repo definition file is not
reporting correct versions on blueprint install
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46389/
-----------------------------------------------------------
(Updated April 19, 2016, 10:53 a.m.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
Bugs: AMBARI-15977
https://issues.apache.org/jira/browse/AMBARI-15977
Repository: ambari
Description
-------
When using a public VDF, the version is not precisely known like a local VDF is. The version comes in as, say, 2.5.0.0 (instead of 2.5.0.0-1111 eg). Installation commands will take the repository_version_id as a pass-through in the structured out of the command. When it returns in the response, the StackVersionListener can then update the correct record in the case of a mismatch.
Also corrected a version display issue for dry_run and XML validation when invalid by-hand repos are uploaded that don't specify XSD.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/script/script.py 31d7b2a
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 31635ed
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 8e50da6
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 58bab59
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a85f939
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java b5b12d8
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionAdvertisedEvent.java 11ca72b
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 2a627dd
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java 685a07c
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 709781e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java 3637cab
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java 784830d
ambari-server/src/test/java/org/apache/ambari/server/view/ViewDirectoryWatcherTest.java d9f8919
ambari-server/src/test/python/custom_actions/TestInstallPackages.py e62978a
Diff: https://reviews.apache.org/r/46389/diff/
Testing
-------
Manual. Automated pending.
Thanks,
Nate Cole