[GitHub] [iceberg] manisin commented on a diff in pull request #7176: Add unique JDBC application identifier and user agent header

["manisin (via GitHub)" <gi...@apache.org>]

manisin commented on code in PR #7176:
URL: https://github.com/apache/iceberg/pull/7176#discussion_r1190224787


##########
snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java:
##########
@@ -114,9 +121,13 @@ public void initialize(String name, Map<String, String> properties) {
           cnfe);
     }
 
+    String uniqueId = UUID.randomUUID().toString().replace("-", "").substring(0, UNIQUE_ID_LENGTH);

Review Comment:
   Thanks for the review @danielcweeks ! I have added iceberg version and commit. The Unique identifier part is still required to correlate header with JDBC sessions in our telemetry. Also I have to move this PR to https://github.com/apache/iceberg/pull/7580 due to bad rebase.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org