[GitHub] [tvm] mkatanbaf commented on a diff in pull request #12125: Zephyr fvp support

[GitBox <gi...@apache.org>]

mkatanbaf commented on code in PR #12125:
URL: https://github.com/apache/tvm/pull/12125#discussion_r940626946


##########
apps/microtvm/zephyr/template_project/microtvm_api_server.py:
##########
@@ -564,21 +599,49 @@ def generate_project(self, model_library_format_path, standalone_crt_dir, projec
     def build(self, options):
         BUILD_DIR.mkdir()
 
-        check_call(["cmake", ".."], cwd=BUILD_DIR)
+        zephyr_board = self._find_board_from_cmake_file()

Review Comment:
   I believe the main motivation for using ninja was to reduce the build time.



##########
apps/microtvm/zephyr/template_project/src/host_driven/main.c:
##########
@@ -44,6 +43,12 @@
 #include <unistd.h>
 #include <zephyr.h>
 
+#ifdef FVP
+#include <irq.h>
+

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org