[GitHub] [spark] viirya commented on a change in pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow
URL: https://github.com/apache/spark/pull/25625#discussion_r319332491
 
 

 ##########
 File path: .github/workflows/master.yml
 ##########
 @@ -24,4 +24,4 @@ jobs:
       run: |
         export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=512m -Dorg.slf4j.simpleLogger.defaultLogLevel=WARN"
         export MAVEN_CLI_OPTS="--no-transfer-progress"
-        ./build/mvn $MAVEN_CLI_OPTS -DskipTests package
+        ./build/mvn $MAVEN_CLI_OPTS -DskipTests -Djava.version=${{ matrix.java }} package
 
 Review comment:
   When we run mvn, its java.version property is 1.8, if not specified. Even we use matrix, I think mvn should still build with 1.8?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org