You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/05/05 00:44:47 UTC

[GitHub] [orc] autumnust commented on pull request #694: ORC-793: Fix the typo in setInt method within OrcConf

autumnust commented on pull request #694:
URL: https://github.com/apache/orc/pull/694#issuecomment-832345861


   > Thank you so much, @autumnust .
   > 
   > Although this is a correct fix and `void getInt` doesn't make senses, Apache ORC follows [semantic versioning](https://semver.org) rule. We cannot remove a public method like this at Apache ORC 1.7.x.
   > 
   > Instead, could you add a new function `public void setInt(Configuration conf, int value)` and add a deprecated annotation and description to the wrong old function, `public void getInt()`, please? And, the PR title and description should be revised accordingly.
   > 
   > cc @omalley , @pgaref , @wgtmac , @williamhyun
   
   thanks for suggestions. @dongjoon-hyun  Do you think it is necessary to make the original incorrect `getInt` a noop? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org