You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/02/02 04:58:13 UTC

[kudu-CR] client: rename various function calls and classes to ConnectToCluster 

Hello Dan Burkert, Alexey Serbin,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5868

to review the following change.

Change subject: client: rename various function calls and classes to ConnectToCluster
......................................................................

client: rename various function calls and classes to ConnectToCluster

This is a straight rename patch in preparation for adding the fetching
of authentication tokens and CA information upon first connection to the
master.

Change-Id: I96bdfc1c6bb3758841d31d728b168bac8ac78ec0
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/master_rpc.cc
M src/kudu/client/master_rpc.h
M src/kudu/client/meta_cache.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/master/master.proto
8 files changed, 76 insertions(+), 73 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/5868/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I96bdfc1c6bb3758841d31d728b168bac8ac78ec0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>

[kudu-CR] client: rename various function calls and classes to ConnectToCluster

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: client: rename various function calls and classes to ConnectToCluster
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5868/2/src/kudu/master/master.proto
File src/kudu/master/master.proto:

PS2, Line 633: use
Nit: heh, now we have singular/plural confusion. But feel free to punt.


-- 
To view, visit http://gerrit.cloudera.org:8080/5868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96bdfc1c6bb3758841d31d728b168bac8ac78ec0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] client: rename various function calls and classes to ConnectToCluster

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: client: rename various function calls and classes to ConnectToCluster
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5868/2/src/kudu/master/master.proto
File src/kudu/master/master.proto:

Line 631:   // TODO(todd): rename this RPC to ConnectToCluster() or somesuch. It's only used by
> Could we just add an extension to the protobuf service generator that allow
well, this TODO is sort of obviated by the next patch. take a look and see what you think.


PS2, Line 633: use
> Nit: heh, now we have singular/plural confusion. But feel free to punt.
ha. woops. ya, this TODO goes away in the next patch anyway!


-- 
To view, visit http://gerrit.cloudera.org:8080/5868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96bdfc1c6bb3758841d31d728b168bac8ac78ec0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] client: rename various function calls and classes to ConnectToCluster

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: client: rename various function calls and classes to ConnectToCluster
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

LGTM, consider fixing a tiny typo before committing.

http://gerrit.cloudera.org:8080/#/c/5868/1/src/kudu/master/master.proto
File src/kudu/master/master.proto:

PS1, Line 633: s
typo: an extra 's' symbol


-- 
To view, visit http://gerrit.cloudera.org:8080/5868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96bdfc1c6bb3758841d31d728b168bac8ac78ec0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes

[kudu-CR] client: rename various function calls and classes to ConnectToCluster

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: client: rename various function calls and classes to ConnectToCluster
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5868/1/src/kudu/master/master.proto
File src/kudu/master/master.proto:

PS1, Line 633: s
> typo: an extra 's' symbol
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96bdfc1c6bb3758841d31d728b168bac8ac78ec0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] client: rename various function calls and classes to ConnectToCluster

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: client: rename various function calls and classes to ConnectToCluster
......................................................................


client: rename various function calls and classes to ConnectToCluster

This is a straight rename patch in preparation for adding the fetching
of authentication tokens and CA information upon first connection to the
master.

Change-Id: I96bdfc1c6bb3758841d31d728b168bac8ac78ec0
Reviewed-on: http://gerrit.cloudera.org:8080/5868
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/master_rpc.cc
M src/kudu/client/master_rpc.h
M src/kudu/client/meta_cache.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/master/master.proto
8 files changed, 75 insertions(+), 73 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Todd Lipcon: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I96bdfc1c6bb3758841d31d728b168bac8ac78ec0
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] client: rename various function calls and classes to ConnectToCluster

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: client: rename various function calls and classes to ConnectToCluster
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5868/2/src/kudu/master/master.proto
File src/kudu/master/master.proto:

Line 631:   // TODO(todd): rename this RPC to ConnectToCluster() or somesuch. It's only used by
Could we just add an extension to the protobuf service generator that allows us to define two service names for a method?


-- 
To view, visit http://gerrit.cloudera.org:8080/5868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96bdfc1c6bb3758841d31d728b168bac8ac78ec0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] client: rename various function calls and classes to ConnectToCluster

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: client: rename various function calls and classes to ConnectToCluster
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96bdfc1c6bb3758841d31d728b168bac8ac78ec0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] client: rename various function calls and classes to ConnectToCluster

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5868

to look at the new patch set (#2).

Change subject: client: rename various function calls and classes to ConnectToCluster
......................................................................

client: rename various function calls and classes to ConnectToCluster

This is a straight rename patch in preparation for adding the fetching
of authentication tokens and CA information upon first connection to the
master.

Change-Id: I96bdfc1c6bb3758841d31d728b168bac8ac78ec0
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/master_rpc.cc
M src/kudu/client/master_rpc.h
M src/kudu/client/meta_cache.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/master/master.proto
8 files changed, 75 insertions(+), 73 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/5868/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I96bdfc1c6bb3758841d31d728b168bac8ac78ec0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] client: rename various function calls and classes to ConnectToCluster

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: client: rename various function calls and classes to ConnectToCluster
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96bdfc1c6bb3758841d31d728b168bac8ac78ec0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No