You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by "Gary Gregory (JIRA)" <ji...@apache.org> on 2016/08/01 19:15:20 UTC

[jira] [Comment Edited] (LOG4J2-1482) Improper header in CsvParameterLayout

    [ https://issues.apache.org/jira/browse/LOG4J2-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401636#comment-15401636 ] 

Gary Gregory edited comment on LOG4J2-1482 at 8/1/16 7:14 PM:
--------------------------------------------------------------

Hi Gary,

Following is the java code I am using to generate the sample files.

{code:java}
public class CSVUsingLog {
	private static final Logger logger = LoggerFactory.getLogger("auditcsvfile");
	public static void main(String[] args) {
		int val1 = 9, val2 = 11, val3 = 12;
		logger.info("Info Message!", val1, val2, val3);
		logger.info("Info Message!", val1, val2, val3);
		logger.info("Info Message!", val1, val2, val3);
	}
}
{code}
I run the same code multiple times to test file rollover. I am using the configuration mentioned in the description.

Sumit


was (Author: sumit23):
Hi Gary,

Following is the java code I am using to generate the sample files.

public class CSVUsingLog {
	private static final Logger logger = LoggerFactory.getLogger("auditcsvfile");
	public static void main(String[] args) {
		int val1 = 9, val2 = 11, val3 = 12;
		logger.info("Info Message!", val1, val2, val3);
		logger.info("Info Message!", val1, val2, val3);
		logger.info("Info Message!", val1, val2, val3);
	}
	
}

I run the same code multiple times to test file rollover. I am using the configuration mentioned in the description.

Sumit

> Improper header in CsvParameterLayout
> -------------------------------------
>
>                 Key: LOG4J2-1482
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1482
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.6.2
>            Reporter: Sumit Singhal
>         Attachments: csv-with-line-seprator-1.csv, csv-with-line-seprator-2.csv, csv-without-line-separator-1.csv, csv-without-line-separator-2.csv
>
>
> The header and first record are coming in first line in case of CsvParameterLayout. This messes up the header for the first file as well as for the subsequent files. And if we use line separator as part of header, the first file seems ok but the first record in subsequent files comes out to be empty with only commas.
> Copied from the SO post:
> {code:xml}
> <?xml version="1.0" encoding="UTF-8"?>
> <Configuration status="warn" name="MyApp" packages="">
>     <Properties>
>         <Property name="audit-path">D:/watcher</Property>
>         <Property name="file-name">audit</Property>
>         <Property name="file-header">param1,param2,param3</Property>
>     </Properties>
>     <Appenders>
>     <RollingFile name="auditfile"
>         fileName="${audit-path}/${file-name}.tmp" filePattern="${audit-path}/${file-name}-%d{yyyy-MM-dd}-%i.csv">
>         <CsvParameterLayout delimiter="," header="${file-header}">
>         </CsvParameterLayout>
>         <Policies>
>             <SizeBasedTriggeringPolicy size="80 B" />
>         </Policies>
>         <DefaultRolloverStrategy max="2"/>
>     </RollingFile>
> </Appenders>
> <Loggers>
>     <Root level="info">
>         <AppenderRef ref="auditfile" />
>     </Root>
> </Loggers>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org