You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/04/17 06:12:30 UTC

[GitHub] [echarts] villebro opened a new pull request #14693: fix(markLine): symbolOffset incorrectly marked as mandatory

villebro opened a new pull request #14693:
URL: https://github.com/apache/echarts/pull/14693


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   ### What does this PR do?
   
   When upgrading the ECharts dependency in Superset from 5.0.2 to 5.1.0, I noticed that `symbolOffset` in `MarkLine1DDataItemOption` is marked as mandatory, while it's optional in `MarkLine2DDataItemOption`. I believe this parameter can be made optional.
   
   ### Fixed issues
   
   - Incorrect type checking
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on pull request #14693: fix(markLine): symbolOffset incorrectly marked as mandatory

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14693:
URL: https://github.com/apache/echarts/pull/14693#issuecomment-821774408


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on pull request #14693: fix(markLine): symbolOffset incorrectly marked as mandatory

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14693:
URL: https://github.com/apache/echarts/pull/14693#issuecomment-821783164


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] plainheart merged pull request #14693: fix(markLine): symbolOffset incorrectly marked as mandatory

Posted by GitBox <gi...@apache.org>.
plainheart merged pull request #14693:
URL: https://github.com/apache/echarts/pull/14693


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] plainheart commented on pull request #14693: fix(markLine): symbolOffset incorrectly marked as mandatory

Posted by GitBox <gi...@apache.org>.
plainheart commented on pull request #14693:
URL: https://github.com/apache/echarts/pull/14693#issuecomment-821783138


   > is it ok to merge now?
   
   I think this should be okay.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] villebro commented on pull request #14693: fix(markLine): symbolOffset incorrectly marked as mandatory

Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #14693:
URL: https://github.com/apache/echarts/pull/14693#issuecomment-821783271


   Btw sorry for not catching this sooner! I meant to test the 5.1.0 release candidate, but I ran out of time before the vote was closed. But anyway, this is mostly a cosmetic issue, so probably not something that requires a new release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] villebro commented on pull request #14693: fix(markLine): symbolOffset incorrectly marked as mandatory

Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #14693:
URL: https://github.com/apache/echarts/pull/14693#issuecomment-821782996


   Thanks for the review @plainheart - is it ok to merge now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org