[jira] [Commented] (CALCITE-1400) AggregatePullUpConstantsRule might adjust aggregation function parameters indices wrongly

["Jesus Camacho Rodriguez (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531107#comment-15531107 ] 

Jesus Camacho Rodriguez commented on CALCITE-1400:
--------------------------------------------------

PR with fix is in : https://github.com/apache/calcite/pull/289

Tests pass w/o the fix. I still need to add a new test case to cover this, but it should not be too difficult.

> AggregatePullUpConstantsRule might adjust aggregation function parameters indices wrongly
> -----------------------------------------------------------------------------------------
>
>                 Key: CALCITE-1400
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1400
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.9.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>
> I explored a bit and I think this is a piece missing in CALCITE-1038. Introducing a Project operator below as part of the rewriting was removed, and thus, there is no need to adjust the indices of the aggregation function parameters. However, the code is still there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)