[GitHub] [druid] gianm commented on a diff in pull request #14105: MSQ: Subclass CalciteJoinQueryTest, other supporting changes.

["gianm (via GitHub)" <gi...@apache.org>]

gianm commented on code in PR #14105:
URL: https://github.com/apache/druid/pull/14105#discussion_r1176930515


##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteJoinQueryTest.java:
##########
@@ -640,28 +660,28 @@ public void testFilterAndGroupByLookupUsingJoinOperatorAllowNulls(Map<String, Ob
 
     testQuery(
         "SELECT lookyloo.v, COUNT(*)\n"
-            + "FROM foo LEFT JOIN lookup.lookyloo ON foo.dim2 = lookyloo.k\n"
-            + "WHERE lookyloo.v <> 'xa' OR lookyloo.v IS NULL\n"
-            + "GROUP BY lookyloo.v",
+        + "FROM foo LEFT JOIN lookup.lookyloo ON foo.dim2 = lookyloo.k\n"

Review Comment:
   Ah, yeah, that was the result of applying formatting in IntelliJ. I guess the last time this file was updated, the formatting wasn't applied. To help with reading the diff, Github has this "hide whitespace" feature for PR diffs. If you turn that on it looks like this:
   
   https://github.com/apache/druid/pull/14105/files/ec47a89a785eaf5144aaf9db4752b29e002457c0?w=1#diff-4d1d101fd375322e3a765ae6aa738283f84967d508cf8afccf6f1572af2cd1c7
   
   The substantive changes are indeed adding various `notMsqCompatible` and `sortIfSortBased`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org