You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "thomasrebele (via GitHub)" <gi...@apache.org> on 2026/07/10 15:16:24 UTC
[PR] [CALCITE-7650] Bytecode by JDK 11 is invalid due to Checker Framework annotations [calcite]
thomasrebele opened a new pull request, #5093:
URL: https://github.com/apache/calcite/pull/5093
## Jira Link
[CALCITE-7650](https://issues.apache.org/jira/browse/CALCITE-7650)
## Changes Proposed
Remove a few Checker Framework annotations to fix the bytecode produced by JDK 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7650] Bytecode by JDK 11 is invalid due to Checker Framework annotations [calcite]
Posted by "rubenada (via GitHub)" <gi...@apache.org>.
rubenada commented on code in PR #5093:
URL: https://github.com/apache/calcite/pull/5093#discussion_r3571540921
##########
file/src/main/java/org/apache/calcite/adapter/file/JsonScannableTable.java:
##########
@@ -46,11 +46,20 @@ public JsonScannableTable(Source source) {
}
@Override public Enumerable<@Nullable Object[]> scan(DataContext root) {
- return new AbstractEnumerable<@Nullable Object[]>() {
- @Override public Enumerator<@Nullable Object[]> enumerator() {
- JavaTypeFactory typeFactory = root.getTypeFactory();
- return new JsonEnumerator(getDataList(typeFactory));
- }
- };
+ return new JsconScannableTableEnumerable(root);
+ }
+
+ /** Enumerable for {@link JsonScannableTable}. */
+ private class JsconScannableTableEnumerable extends AbstractEnumerable<@Nullable Object[]> {
Review Comment:
Typo: Js**c**onScannableTableEnumerable => JsonScannableTableEnumerable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7650] Bytecode by JDK 11 is invalid due to Checker Framework annotations [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5093:
URL: https://github.com/apache/calcite/pull/5093#issuecomment-4957326646
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5093) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5093&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5093&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=5093&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [70.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5093&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5093&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5093)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7650] Bytecode by JDK 11 is invalid due to Checker Framework annotations [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5093:
URL: https://github.com/apache/calcite/pull/5093#issuecomment-4959474825
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5093) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5093&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5093&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=5093&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [70.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5093&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5093&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5093)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7650] Bytecode by JDK 11 is invalid due to Checker Framework annotations [calcite]
Posted by "thomasrebele (via GitHub)" <gi...@apache.org>.
thomasrebele merged PR #5093:
URL: https://github.com/apache/calcite/pull/5093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7650] Bytecode by JDK 11 is invalid due to Checker Framework annotations [calcite]
Posted by "rubenada (via GitHub)" <gi...@apache.org>.
rubenada commented on code in PR #5093:
URL: https://github.com/apache/calcite/pull/5093#discussion_r3571534297
##########
plus/src/main/java/org/apache/calcite/adapter/os/GitCommitsTableFunction.java:
##########
@@ -153,4 +172,6 @@ public static ScannableTable eval(boolean b) {
}
};
}
+
Review Comment:
unnecessary new lines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7650] Bytecode by JDK 11 is invalid due to Checker Framework annotations [calcite]
Posted by "thomasrebele (via GitHub)" <gi...@apache.org>.
thomasrebele commented on code in PR #5093:
URL: https://github.com/apache/calcite/pull/5093#discussion_r3571617137
##########
plus/src/main/java/org/apache/calcite/adapter/os/GitCommitsTableFunction.java:
##########
@@ -153,4 +172,6 @@ public static ScannableTable eval(boolean b) {
}
};
}
+
Review Comment:
I had moved the code introduced by Intellij's refactoring. Seems that I've forgotten to remove the empty lines in one case. Thanks for spotting!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7650] Bytecode by JDK 11 is invalid due to Checker Framework annotations [calcite]
Posted by "thomasrebele (via GitHub)" <gi...@apache.org>.
thomasrebele commented on PR #5093:
URL: https://github.com/apache/calcite/pull/5093#issuecomment-4967896832
Merged, thank you for the review, @rubenada!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7650] Bytecode by JDK 11 is invalid due to Checker Framework annotations [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5093:
URL: https://github.com/apache/calcite/pull/5093#issuecomment-4936996112
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5093) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5093&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5093&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=5093&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [63.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5093&metric=new_coverage&view=list)
 [4.3% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5093&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5093)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7650] Bytecode by JDK 11 is invalid due to Checker Framework annotations [calcite]
Posted by "thomasrebele (via GitHub)" <gi...@apache.org>.
thomasrebele commented on code in PR #5093:
URL: https://github.com/apache/calcite/pull/5093#discussion_r3571619714
##########
file/src/main/java/org/apache/calcite/adapter/file/JsonScannableTable.java:
##########
@@ -46,11 +46,20 @@ public JsonScannableTable(Source source) {
}
@Override public Enumerable<@Nullable Object[]> scan(DataContext root) {
- return new AbstractEnumerable<@Nullable Object[]>() {
- @Override public Enumerator<@Nullable Object[]> enumerator() {
- JavaTypeFactory typeFactory = root.getTypeFactory();
- return new JsonEnumerator(getDataList(typeFactory));
- }
- };
+ return new JsconScannableTableEnumerable(root);
+ }
+
+ /** Enumerable for {@link JsonScannableTable}. */
+ private class JsconScannableTableEnumerable extends AbstractEnumerable<@Nullable Object[]> {
Review Comment:
Sorry for the typo, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org