[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #837: MINIFICPP-1121 - Upgrade spdlog to version 1.7.0

[GitBox <gi...@apache.org>]

fgerlits commented on a change in pull request #837:
URL: https://github.com/apache/nifi-minifi-cpp/pull/837#discussion_r455631883



##########
File path: libminifi/include/core/PropertyValidation.h
##########
@@ -202,7 +202,7 @@ class UnsignedIntValidator : public PropertyValidator {
 
 class LongValidator : public PropertyValidator {
  public:
-  explicit LongValidator(const std::string &name, int64_t min = (std::numeric_limits<int64_t>::min)(), int64_t max = (std::numeric_limits<int64_t>::max)())
+  explicit LongValidator(const std::string &name, int64_t min = std::numeric_limits<int64_t>::min(), int64_t max = (std::numeric_limits<int64_t>::max)())

Review comment:
       the `()` around `max` can be removed, too




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org