You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2010/05/01 22:59:56 UTC

[jira] Created: (HBASE-2508) Use AtomicInteger for lockIdGenerator in HRegion

Use AtomicInteger for lockIdGenerator in HRegion
------------------------------------------------

                 Key: HBASE-2508
                 URL: https://issues.apache.org/jira/browse/HBASE-2508
             Project: Hadoop HBase
          Issue Type: Improvement
          Components: regionserver
    Affects Versions: 0.20.3
            Reporter: Ted Yu


Currently lockIdGenerator is an int. In obtainRowLock(), retry is needed in case of lockId collisions.

We can declare lockIdGenerator as AtomicInteger and use incrementAndGet() to get the next lock Id.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-2508) Use AtomicInteger for lockIdGenerator in HRegion

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson resolved HBASE-2508.
--------------------------------

    Resolution: Invalid

as per how the JMM does things and the described locking and lack of evidence to why what we have now is bad, I am closing this. It's really not an issue. 

> Use AtomicInteger for lockIdGenerator in HRegion
> ------------------------------------------------
>
>                 Key: HBASE-2508
>                 URL: https://issues.apache.org/jira/browse/HBASE-2508
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.20.3
>            Reporter: Ted Yu
>
> Currently lockIdGenerator is an int. In obtainRowLock(), retry is needed in case of lockId collisions.
> We can declare lockIdGenerator as AtomicInteger and use incrementAndGet() to get the next lock Id.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.