You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "aiguofer (via GitHub)" <gi...@apache.org> on 2023/03/31 04:52:56 UTC

[GitHub] [arrow] aiguofer commented on pull request #34815: GH-34778: [Java] Add hook to further configure the ServerBuilder in FlightServer

aiguofer commented on PR #34815:
URL: https://github.com/apache/arrow/pull/34815#issuecomment-1491286043

   Upon further looking at the code, it seems that this already exists:
   
   ```
         // Allow hooking into the gRPC builder. This is not guaranteed to be available on all Arrow versions or
         // Flight implementations.
         builderOptions.computeIfPresent("grpc.builderConsumer", (key, builderConsumer) -> {
           final Consumer<NettyServerBuilder> consumer = (Consumer<NettyServerBuilder>) builderConsumer;
           consumer.accept(builder);
           return null;
         });
   ```
   
   I can update the PR to only make the fixes to `ServerInterceptorAdapter.java` so it won't throw an exception on non-flight requests and add some docs on how to add extra services.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org