[GitHub] haojin2 commented on a change in pull request #12010: Adjusting tolerance level and removing fixed seed for tests: test_ifft, test_fft

[GitBox <gi...@apache.org>]

haojin2 commented on a change in pull request #12010: Adjusting tolerance level and removing fixed seed for tests: test_ifft, test_fft
URL: https://github.com/apache/incubator-mxnet/pull/12010#discussion_r207621556
 
 

 ##########
 File path: tests/python/gpu/test_operator_gpu.py
 ##########
 @@ -163,9 +163,11 @@ def check_ifft(shape):
                 temp[:,:,:,i] = exe.grad_arrays[0].asnumpy()[:,:,:,2*i]
 
         a = np.fft.fft(out_grad.asnumpy(), n=None, axis=-1, norm=None)
-        assert_almost_equal(a.real, temp, rtol=1e-3, atol=1e-12)
+        assert_almost_equal(a.real, temp, rtol=1e-3, atol=1e-5)
 
-@with_seed(0)
+# @roshrini - removing fixed seed for this test. raised tolerance level.
+# Issue to track: https://github.com/apache/incubator-mxnet/issues/11731
 
 Review comment:
   Feel free to remove those comments and simply link the issue in PR description.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services