You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/23 09:31:06 UTC
[GitHub] [ratis] codings-dan opened a new pull request, #723: RATIS-1684. Upgrade Ratis Thirdparty to 1.0.2
codings-dan opened a new pull request, #723:
URL: https://github.com/apache/ratis/pull/723
## What changes were proposed in this pull request?
Upgrade Ratis Thirdparty to 1.0.2, which has the following (non-test) changes:
RATIS-1600. Add protobuf-java-util
RATIS-1632. Upgrade gRPC to 1.48.1
RATIS-1664. Exclude org.slf4j.* in ratis-thirdparty-misc
RATIS-1679. Shade io.perfmark:perfmark-api in ratis-thirdparty
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1684
## How was this patch tested?
https://github.com/codings-dan/incubator-ratis/actions/runs/2910213305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] codings-dan commented on pull request #723: RATIS-1684. Upgrade Ratis Thirdparty to 1.0.2
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #723:
URL: https://github.com/apache/ratis/pull/723#issuecomment-1223814307
@szetszwo Could you help take a look at the pull request? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] codings-dan commented on pull request #723: RATIS-1684. Upgrade Ratis Thirdparty to 1.0.2
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #723:
URL: https://github.com/apache/ratis/pull/723#issuecomment-1223890730
> Thanks @codings-dan for the patch.
>
> https://github.com/apache/ratis/blob/fa2ec7c2d520b874377633ac225923b75d8c1830/pom.xml#L212
>
> I think `shaded.grpc.version` should be changed to match:
>
> https://github.com/apache/ratis-thirdparty/blob/1.0.2/pom.xml#L73
Good catch! I have match the grpc version, PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #723: RATIS-1684. Upgrade Ratis Thirdparty to 1.0.2
Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #723:
URL: https://github.com/apache/ratis/pull/723#issuecomment-1224326568
@codings-dan , could you also remove shaded.dropwizard.* as below? They are not used anywhere.
```
+++ b/pom.xml
@@ -216,10 +216,6 @@
<test.exclude.pattern>_</test.exclude.pattern>
<!-- number of threads/forks to use when running tests in parallel, see parallel-tests profile -->
<testsThreadCount>4</testsThreadCount>
-
- <!--metrics-->
- <shaded.dropwizard.version>4.2.9</shaded.dropwizard.version>
- <shaded.dropwizard.ganglia.version>3.2.6</shaded.dropwizard.ganglia.version>
</properties>
<dependencyManagement>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] codings-dan commented on pull request #723: RATIS-1684. Upgrade Ratis Thirdparty to 1.0.2
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #723:
URL: https://github.com/apache/ratis/pull/723#issuecomment-1225080423
@szetszwo Thanks for helping review the code, I have changed it, PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo merged pull request #723: RATIS-1684. Upgrade Ratis Thirdparty to 1.0.2
Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #723:
URL: https://github.com/apache/ratis/pull/723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org