You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Rutuja123-dos (via GitHub)" <gi...@apache.org> on 2025/12/30 09:52:16 UTC
[PR] MAHOUT-743: Add regression test for async amplitude chunk bounds [mahout]
Rutuja123-dos opened a new pull request, #773:
URL: https://github.com/apache/mahout/pull/773
### Purpose of PR
Adds a regression test to ensure async amplitude encoding respects 'chunk_len'
instead of writing the full 'state_len', preventing out-of-bounds writes for
non-first chunks.
### Related Issues or PRs
- Fixes #743
### Changes Made
<!-- Please mark one with an "x" -->
- [ ] Bug fix
- [ ] New feature
- [ ] Refactoring
- [ ] Documentation
- [ ] Test
- [ ] CI/CD pipeline
- [ ] Other
### Breaking Changes
<!-- Does this PR introduce a breaking change? -->
- [ ] Yes
- [ ] No
### Checklist
<!-- Please mark each item with an "x" when complete -->
<!-- If not all items are complete, please open this as a **Draft PR**.
Once all requirements are met, mark as ready for review. -->
- [ ] Added or updated unit tests for all changes
- [ ] Added or updated documentation for all changes
- [ ] Successfully built and ran all unit tests or manual tests locally
- [ ] PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
- [ ] Code follows ASF guidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MAHOUT-743: Add regression test for async amplitude chunk bounds [mahout]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #773:
URL: https://github.com/apache/mahout/pull/773#issuecomment-3701694993
@Rutuja123-dos thanks for the patch , you should aim to dev-qdp branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MAHOUT-743: Add regression test for async amplitude chunk bounds [mahout]
Posted by "Rutuja123-dos (via GitHub)" <gi...@apache.org>.
Rutuja123-dos commented on PR #773:
URL: https://github.com/apache/mahout/pull/773#issuecomment-3702138603
@rich7420 thanks for clarification. I will retarget the PR to the dev-qdp branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MAHOUT-743: Add regression test for async amplitude chunk bounds [mahout]
Posted by "Rutuja123-dos (via GitHub)" <gi...@apache.org>.
Rutuja123-dos closed pull request #773: MAHOUT-743: Add regression test for async amplitude chunk bounds
URL: https://github.com/apache/mahout/pull/773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MAHOUT-743: Add regression test for async amplitude chunk bounds [mahout]
Posted by "Rutuja123-dos (via GitHub)" <gi...@apache.org>.
Rutuja123-dos commented on PR #773:
URL: https://github.com/apache/mahout/pull/773#issuecomment-3758972769
@ryankert01 I have now updated the PR with a clean force-push. It now contains only the regression test for MAHOUT-743 with proper formatting and license headers. Ready for review. let me know if there should be any changes. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MAHOUT-743: Add regression test for async amplitude chunk bounds [mahout]
Posted by "ryankert01 (via GitHub)" <gi...@apache.org>.
ryankert01 commented on PR #773:
URL: https://github.com/apache/mahout/pull/773#issuecomment-3758549105
@Rutuja123-dos How's it going so far? Any questions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MAHOUT-743: Add regression test for async amplitude chunk bounds [mahout]
Posted by "Rutuja123-dos (via GitHub)" <gi...@apache.org>.
Rutuja123-dos commented on PR #773:
URL: https://github.com/apache/mahout/pull/773#issuecomment-3758750048
Hi @ryankert01, apologies for the delay! I was busy with my university semester exams over the last two weeks, so I couldn't get to this sooner.
I am back now and will be working on cleaning up the PR to remove the unrelated commits and focus strictly on MAHOUT-743. I’ll have the updated, clean version pushed by tomorrow. Thanks for your patience
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org