You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2015/06/02 12:31:26 UTC
[GitHub] incubator-brooklyn pull request: Improve policy support for catalo...
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/670
Improve policy support for catalog items
* policies found through scanning the classpath will be added with the correct yaml markup
* support for nested catalog item loading for policies, plus infinite recursion avoidance check
* fix catalog item type detection for non-entities
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn fix/catalog-scan
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/670.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #670
----
commit 580c8cdb181afa132776044d13db16a8e0d08a03
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-06-02T10:30:39Z
Improve policy support for catalog items
* policies found through scanning the classpath will be added with the correct yaml markup
* support for nested catalog item loading for policies, plus infinite recursion avoidance check
* fix catalog item type detection for non-entities
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-148] Improve policy sup...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/670#issuecomment-107915415
+1, looks OK to merge :frog:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-148] Improve policy sup...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/670#issuecomment-108021734
good fixes, merging #668 #669 #670
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-148] Improve policy sup...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/670#issuecomment-107912049
Fix for https://issues.apache.org/jira/browse/BROOKLYN-148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-148] Improve policy sup...
Posted by csabapalfi <gi...@git.apache.org>.
Github user csabapalfi commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/670#issuecomment-107913138
Looks good to me. Works locally now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-148] Improve policy sup...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/670
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---