You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/12 15:09:10 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #13115: RFC: [Format] Add canonical include guard for C Data Interface

pitrou commented on code in PR #13115:
URL: https://github.com/apache/arrow/pull/13115#discussion_r871504287


##########
cpp/src/arrow/c/abi.h:
##########
@@ -60,8 +63,21 @@ struct ArrowArray {
   void* private_data;
 };
 
+#ifdef __cplusplus

Review Comment:
   I would put the `__cplusplus` guards outside of the canonical C data guards, so that it's a simple copy/paste job from the spec.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org