You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/12 03:26:57 UTC
[GitHub] [incubator-doris] yixiutt opened a new pull request, #9518: [bugfix](load) fix coredump in ordinal index flush
yixiutt opened a new pull request, #9518:
URL: https://github.com/apache/incubator-doris/pull/9518
commit #9123 introduce the bug. bitshuffle page return error when
page is full, so scalar column write cannot switch to next page, which make
ordinal index is null when flush.
All page builder should return ok when page full, and column writer procedure
shoud be append_data, check is_page_full, switch to next page
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
ScalarColumn write cannot switch to next page cause page builder return false when page full
coredump is here:
@ 0x556a329945f9 google::LogMessageFatal::~LogMessageFatal()
@ 0x556a329945f9 google::LogMessageFatal::~LogMessageFatal()
@ 0x556a316d7677 doris::segment_v2::OrdinalIndexWriter::finish()
@ 0x556a309d6809 doris::FlushToken::_flush_memtable()
@ 0x556a309d6809 doris::FlushToken::_flush_memtable()
@ 0x556a316d7677 doris::segment_v2::OrdinalIndexWriter::finish()
@ 0x556a309d7590 std::_Function_handler<>::_M_invoke()
@ 0x556a309d7590 std::_Function_handler<>::_M_invoke()
@ 0x556a316d0c8e doris::segment_v2::ScalarColumnWriter::write_ordinal_index()
@ 0x556a316d0c8e doris::segment_v2::ScalarColumnWriter::write_ordinal_index()
@ 0x556a30d7cacd doris::ThreadPool::dispatch_thread()
@ 0x556a30d7cacd doris::ThreadPool::dispatch_thread()
@ 0x556a316724b5 doris::segment_v2::SegmentWriter::finalize()
@ 0x556a30d7733f doris::Thread::supervise_thread()
@ 0x556a30d7733f doris::Thread::supervise_thread()
@ 0x556a316724b5 doris::segment_v2::SegmentWriter::finalize()
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9518: [bugfix](load) fix coredump in ordinal index flush
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9518:
URL: https://github.com/apache/incubator-doris/pull/9518#issuecomment-1124615079
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9518: [bugfix](load) fix coredump in ordinal index flush
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9518:
URL: https://github.com/apache/incubator-doris/pull/9518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9518: [bugfix](load) fix coredump in ordinal index flush
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #9518:
URL: https://github.com/apache/incubator-doris/pull/9518#discussion_r870921633
##########
be/src/olap/rowset/segment_v2/binary_dict_page.cpp:
##########
@@ -75,6 +75,9 @@ Status BinaryDictPageBuilder::add(const uint8_t* vals, size_t* count) {
}
for (int i = 0; i < *count; ++i, ++src) {
+ if (actual_builder->is_page_full) {
Review Comment:
is_page_full()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org