You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by mb...@apache.org on 2015/05/19 15:55:37 UTC
svn commit: r1680293 - in /ofbiz/branches/release14.12: ./
applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
Author: mbrohl
Date: Tue May 19 13:55:36 2015
New Revision: 1680293
URL: http://svn.apache.org/r1680293
Log:
Applied fix from trunk for revision: 1680288
===
Applied patch from jira issue OFBIZ-6258: Trivial perfomance improvement for creating OrderItemAttributes during store/update Order.
Thanks Martin Becker for reporting the issue and providing the patch.
Modified:
ofbiz/branches/release14.12/ (props changed)
ofbiz/branches/release14.12/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
Propchange: ofbiz/branches/release14.12/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue May 19 13:55:36 2015
@@ -8,4 +8,4 @@
/ofbiz/branches/json-integration-refactoring:1634077-1635900
/ofbiz/branches/multitenant20100310:921280-927264
/ofbiz/branches/release13.07:1547657
-/ofbiz/trunk:1649072,1649083-1649084,1649086,1649090,1649096,1649230,1649238-1649239,1649248,1649272,1649275,1649280-1649281,1649283,1649285-1649286,1649291,1649329,1649331,1649384,1649393,1649666,1649742,1650240,1650348,1650357,1650583,1650642,1650678,1650821,1650882,1650887,1650938,1651593,1652312,1652361,1652638,1652641,1652672,1652688,1652706,1652725,1652731,1652739,1652852,1653248,1653296,1653456,1653597,1653614,1654175,1654273,1654509,1654670,1654672-1654673,1654683-1654684,1654824,1655046,1655668,1655979,1656014,1656185,1656198,1656445,1656983,1657323,1657506-1657507,1657514,1657714,1657790,1657848,1658364,1658662,1658882,1659224,1659965,1660031,1660053,1660389,1660444,1660579,1661303,1661328,1661760,1661778,1661853,1661862,1661873,1661940,1661951,1661977,1662119-1662120,1662361,1662500,1662812,1662919,1663202,1663912,1663979,1664602,1664604,1664696,1665154,1665162,1665535,1666404,1666511,1666633,1666836,1666939,1666949,1666958,1667055,1667253,1667483,1667492,1667774,1668207,
1668214,1668236,1668246,1668258,1668263,1668265,1668270,1668277,1668314,1668657,1669317,1669588,1672427,1672430,1672846,1672853,1672856,1672862,1672873,1673764,1674447,1674464,1674491,1674496,1674908,1676674,1677123,1677597,1677769-1677770,1678294,1678882,1678911,1679689,1679697,1679709,1679720,1679728,1679732,1679957
+/ofbiz/trunk:1649072,1649083-1649084,1649086,1649090,1649096,1649230,1649238-1649239,1649248,1649272,1649275,1649280-1649281,1649283,1649285-1649286,1649291,1649329,1649331,1649384,1649393,1649666,1649742,1650240,1650348,1650357,1650583,1650642,1650678,1650821,1650882,1650887,1650938,1651593,1652312,1652361,1652638,1652641,1652672,1652688,1652706,1652725,1652731,1652739,1652852,1653248,1653296,1653456,1653597,1653614,1654175,1654273,1654509,1654670,1654672-1654673,1654683-1654684,1654824,1655046,1655668,1655979,1656014,1656185,1656198,1656445,1656983,1657323,1657506-1657507,1657514,1657714,1657790,1657848,1658364,1658662,1658882,1659224,1659965,1660031,1660053,1660389,1660444,1660579,1661303,1661328,1661760,1661778,1661853,1661862,1661873,1661940,1661951,1661977,1662119-1662120,1662361,1662500,1662812,1662919,1663202,1663912,1663979,1664602,1664604,1664696,1665154,1665162,1665535,1666404,1666511,1666633,1666836,1666939,1666949,1666958,1667055,1667253,1667483,1667492,1667774,1668207,
1668214,1668236,1668246,1668258,1668263,1668265,1668270,1668277,1668314,1668657,1669317,1669588,1672427,1672430,1672846,1672853,1672856,1672862,1672873,1673764,1674447,1674464,1674491,1674496,1674908,1676674,1677123,1677597,1677769-1677770,1678294,1678882,1678911,1679689,1679697,1679709,1679720,1679728,1679732,1679957,1680288
Modified: ofbiz/branches/release14.12/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
URL: http://svn.apache.org/viewvc/ofbiz/branches/release14.12/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java?rev=1680293&r1=1680292&r2=1680293&view=diff
==============================================================================
--- ofbiz/branches/release14.12/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java (original)
+++ ofbiz/branches/release14.12/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java Tue May 19 13:55:36 2015
@@ -4020,32 +4020,18 @@ public class ShoppingCart implements Ite
for (String key : orderItemAttributes.keySet()) {
String value = orderItemAttributes.get(key);
- GenericValue orderItemAttribute = getDelegator().makeValue("OrderItemAttribute");
- if (UtilValidate.isNotEmpty(orderId)) {
- orderItemAttribute.set("orderId", orderId);
- }
-
- orderItemAttribute.set("orderItemSeqId", item.getOrderItemSeqId());
- orderItemAttribute.set("attrName", key);
- orderItemAttribute.set("attrValue", value);
-
- switch (mode) {
- case ALL:
- result.add(orderItemAttribute);
- break;
- case FILLED_ONLY:
- if (UtilValidate.isNotEmpty(value)) {
- result.add(orderItemAttribute);
- }
- break;
- case EMPTY_ONLY:
- if (UtilValidate.isEmpty(value)) {
- result.add(orderItemAttribute);
+ if (ALL == mode || (FILLED_ONLY == mode && UtilValidate.isNotEmpty(value)) || (EMPTY_ONLY == mode && UtilValidate.isEmpty(value))
+ || (mode != ALL && mode != FILLED_ONLY && mode != EMPTY_ONLY)) {
+
+ GenericValue orderItemAttribute = getDelegator().makeValue("OrderItemAttribute");
+ if (UtilValidate.isNotEmpty(orderId)) {
+ orderItemAttribute.set("orderId", orderId);
}
- break;
- default:
+ orderItemAttribute.set("orderItemSeqId", item.getOrderItemSeqId());
+ orderItemAttribute.set("attrName", key);
+ orderItemAttribute.set("attrValue", value);
+
result.add(orderItemAttribute);
- break;
}
}
}