[GitHub] [flink] beyond1920 commented on issue #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate

[GitBox <gi...@apache.org>]

beyond1920 commented on issue #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate
URL: https://github.com/apache/flink/pull/8389#issuecomment-491659360
 
 
   @walterddr good catch, we also encountered the problem in Blink before. 
   The key question is that the explainSource value of new TableSource should be different with the original one after partition prune or filter push down or query push done, however the method name (explainSource) cannot indicate the meaning explicitly. 
   The solution to pattern match FilterableTableSource in `FlinkLogicalTableSourceScan` is not perfect, since it ignores `PartitionableTableSource`,  `AggregatePushDownTableSource` and so on.
   Maybe it's better to refactor current API `explainSource` in `TableSource` to explicitly indicates the value should be an identifier for this `Tablesource`, the identifier must be unique. That meanings, after project push down or filter push down or query pushdown, the identifier value of new TableSource
   should be different with the original one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services