You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/01 00:23:27 UTC

[GitHub] arunmahadevan commented on a change in pull request #23912: [SPARK-21029][SS] StreamingQuery should be stopped when the SparkSession is stopped

arunmahadevan commented on a change in pull request #23912: [SPARK-21029][SS] StreamingQuery should be stopped when the SparkSession is stopped
URL: https://github.com/apache/spark/pull/23912#discussion_r261440457
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
 ##########
 @@ -742,6 +749,22 @@ class SparkSession private(
     DataType.fromJson(dataTypeString)
   }
 
+  /**
+   * Stops all active streaming queries
+   */
+  private def stopStreamingQueries(): Unit = {
 
 Review comment:
   I 've moved it with `private[sql]`. I don't want to introduce new APIs in StreamingQueryManager.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org