[GitHub] [pinot] mayankshriv edited a comment on pull request #7961: delete tmp- segment directories on server startup

[GitBox <gi...@apache.org>]

mayankshriv edited a comment on pull request #7961:
URL: https://github.com/apache/pinot/pull/7961#issuecomment-1004526326


   Thanks @jadami10 for the PR, much appreciated. Wondering what the root cause is, as in why the files are not cleaned up. Looking at the issue linked, the temp file generated was recently added: https://github.com/apache/pinot/pull/7319 (cc @klsince), or not sure if it existed before too.
   
   My worry is that explicitly cleaning up based on `tmp-` prefix might have some side effects later on (I realize you have put in some guards there). Let me also look at why the files are not being deleted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org