You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2023/12/25 02:27:43 UTC
[PR] [fix](load) fix nullptr when getting memtable flush running count [doris]
kaijchen opened a new pull request, #28942:
URL: https://github.com/apache/doris/pull/28942
## Proposed changes
Fix coredump when accessing flush running count due to flush token is nullptr.
```cpp
Program terminated with signal SIGSEGV, Segmentation fault.
#0 std::__atomic_base<unsigned long>::load (this=0x58, __m=std::memory_order::seq_cst) at /var/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/atomic_base.h:481
481 return __atomic_load_n(&_M_i, int(__m));
[Current thread is 1 (Thread 0x7f3165554700 (LWP 2752768))]
(gdb) bt
#0 std::__atomic_base<unsigned long>::load (this=0x58, __m=std::memory_order::seq_cst)
at /var/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/atomic_base.h:481
#1 std::__atomic_base<unsigned long>::operator unsigned long (this=0x58)
at /var/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/atomic_base.h:341
#2 doris::BaseDeltaWriter::write (this=0x7f319c0bdf80, block=0x7f31655460f0, row_idxs=..., is_append=false)
at /home/zcp/repo_center/doris_master/doris/be/src/olap/delta_writer.cpp:129
#3 0x0000559362af9262 in doris::BaseTabletsChannel::add_batch(doris::PTabletWriterAddBlockRequest const&, doris::PTabletWriterAddBlockResult*)::$_3::operator()(doris::BaseDeltaWriter*) const (writer=0x7f3165545f78, this=<optimized out>)
```
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix nullptr when getting memtable flush running count [doris]
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #28942:
URL: https://github.com/apache/doris/pull/28942#issuecomment-1868675137
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix nullptr when getting memtable flush running count [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28942:
URL: https://github.com/apache/doris/pull/28942#issuecomment-1868681522
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix nullptr when getting memtable flush running count [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28942:
URL: https://github.com/apache/doris/pull/28942#issuecomment-1868700384
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit 3af4581bebc50079de5cb8a86c5c2f3e24e8a3e6, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4710 4422 4454 4422
q2 367 152 156 152
q3 1459 1271 1247 1247
q4 1111 911 890 890
q5 3164 3168 3172 3168
q6 253 134 131 131
q7 992 483 482 482
q8 2174 2217 2202 2202
q9 6676 6646 6664 6646
q10 3248 3252 3294 3252
q11 323 180 199 180
q12 362 216 213 213
q13 4580 3813 3803 3803
q14 238 207 214 207
q15 581 528 521 521
q16 455 390 389 389
q17 991 549 517 517
q18 6990 6908 6920 6908
q19 1513 1423 1440 1423
q20 549 314 316 314
q21 3117 2699 2687 2687
q22 345 275 284 275
Total cold run time: 44198 ms
Total hot run time: 40029 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4332 4340 4340 4340
q2 274 165 172 165
q3 3502 3499 3509 3499
q4 2406 2370 2382 2370
q5 5693 5726 5698 5698
q6 240 124 125 124
q7 2362 1855 1838 1838
q8 3521 3519 3519 3519
q9 9010 8965 8999 8965
q10 3915 3998 4024 3998
q11 494 374 365 365
q12 759 598 587 587
q13 4312 3592 3568 3568
q14 295 248 254 248
q15 576 530 517 517
q16 501 457 456 456
q17 1900 1854 1865 1854
q18 8513 8151 8027 8027
q19 1773 1772 1753 1753
q20 2268 1962 1927 1927
q21 6498 6148 6130 6130
q22 498 411 415 411
Total cold run time: 63642 ms
Total hot run time: 60359 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix nullptr when getting memtable flush running count [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28942:
URL: https://github.com/apache/doris/pull/28942#issuecomment-1868677917
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix nullptr when getting memtable flush running count [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #28942:
URL: https://github.com/apache/doris/pull/28942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix nullptr when getting memtable flush running count [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28942:
URL: https://github.com/apache/doris/pull/28942#issuecomment-1868676905
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix nullptr when getting memtable flush running count [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28942:
URL: https://github.com/apache/doris/pull/28942#issuecomment-1868681500
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix nullptr when getting memtable flush running count [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28942:
URL: https://github.com/apache/doris/pull/28942#issuecomment-1868701136
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.41 seconds
stream load tsv: 570 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17183881568 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) fix nullptr when getting memtable flush running count [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28942:
URL: https://github.com/apache/doris/pull/28942#issuecomment-1868697414
TeamCity be ut coverage result:
Function Coverage: 36.58% (8554/23383)
Line Coverage: 28.66% (69554/242690)
Region Coverage: 27.66% (35975/130055)
Branch Coverage: 24.38% (18382/75394)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3af4581bebc50079de5cb8a86c5c2f3e24e8a3e6_3af4581bebc50079de5cb8a86c5c2f3e24e8a3e6/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org