You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Antoine Toulme (JIRA)" <ji...@apache.org> on 2010/07/21 06:51:50 UTC

[jira] Resolved: (BUILDR-481) Antwrap monkey-patching in core.rb

     [ https://issues.apache.org/jira/browse/BUILDR-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antoine Toulme resolved BUILDR-481.
-----------------------------------

    Resolution: Fixed

21:46:25~/w/buildr>svn ci CHANGELOG buildr.gemspec lib/buildr/core.rb -m "BUILDR-481 Antwrap monkey-patching in core.rb"
Sending        CHANGELOG
Sending        buildr.gemspec
Sending        lib/buildr/core.rb
Transmitting file data ...
Committed revision 966084.

> Antwrap monkey-patching in core.rb
> ----------------------------------
>
>                 Key: BUILDR-481
>                 URL: https://issues.apache.org/jira/browse/BUILDR-481
>             Project: Buildr
>          Issue Type: Task
>            Reporter: Antoine Toulme
>            Assignee: Antoine Toulme
>             Fix For: 1.4.2
>
>
> In core.rb, there is a weird monkey-patching:
> # TODO: Antwrap 0.7 requires this monkeypatch, have it fixed.
> class Array #:nodoc:
>   alias :nitems :size
> end
> Changing ruby core classes is never a good idea, this should be removed and Antwrap should be fixed if needed to support this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.