You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "nextdreamblue (via GitHub)" <gi...@apache.org> on 2023/04/14 09:48:15 UTC
[GitHub] [doris] nextdreamblue opened a new pull request, #18679: [fix][load] add thread pool for sinker
nextdreamblue opened a new pull request, #18679:
URL: https://github.com/apache/doris/pull/18679
# Proposed changes
Issue Number: close #18651
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #18679: (fix)[load] add thread pool for sinker
Posted by "nextdreamblue (via GitHub)" <gi...@apache.org>.
nextdreamblue commented on PR #18679:
URL: https://github.com/apache/doris/pull/18679#issuecomment-1509798134
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #18679: (fix)[load] add thread pool for sinker
Posted by "nextdreamblue (via GitHub)" <gi...@apache.org>.
nextdreamblue commented on PR #18679:
URL: https://github.com/apache/doris/pull/18679#issuecomment-1508618704
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18679: [fix][load] add thread pool for sinker
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18679:
URL: https://github.com/apache/doris/pull/18679#issuecomment-1508264757
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18679: [fix][load] add thread pool for sinker
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18679:
URL: https://github.com/apache/doris/pull/18679#issuecomment-1508264690
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18679: [fix][load] add thread pool for sinker
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #18679:
URL: https://github.com/apache/doris/pull/18679#discussion_r1166617156
##########
be/test/vec/exec/vtablet_sink_test.cpp:
##########
@@ -345,6 +345,11 @@
_env->_master_info = new TMasterInfo();
_env->_internal_client_cache = new BrpcClientCache<PBackendService_Stub>();
Review Comment:
warning: '_internal_client_cache' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
```cpp
_env->_internal_client_cache = new BrpcClientCache<PBackendService_Stub>();
^
```
**be/src/runtime/exec_env.h:248:** declared private here
```cpp
BrpcClientCache<PBackendService_Stub>* _internal_client_cache = nullptr;
^
```
##########
be/test/vec/exec/vtablet_sink_test.cpp:
##########
@@ -345,6 +345,11 @@ class VOlapTableSinkTest : public testing::Test {
_env->_master_info = new TMasterInfo();
Review Comment:
warning: '_master_info' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
```cpp
_env->_master_info = new TMasterInfo();
^
```
**be/src/runtime/exec_env.h:241:** declared private here
```cpp
TMasterInfo* _master_info = nullptr;
^
```
##########
be/test/vec/exec/vtablet_sink_test.cpp:
##########
@@ -345,6 +345,11 @@
_env->_master_info = new TMasterInfo();
_env->_internal_client_cache = new BrpcClientCache<PBackendService_Stub>();
_env->_function_client_cache = new BrpcClientCache<PFunctionService_Stub>();
+ ThreadPoolBuilder("SinkerThreadPool")
+ .set_min_threads(1)
+ .set_max_threads(5)
+ .set_max_queue_size(100)
+ .build(&_env->_sinker_thread_pool);
Review Comment:
warning: '_sinker_thread_pool' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
```cpp
.build(&_env->_sinker_thread_pool);
^
```
**be/src/runtime/exec_env.h:221:** declared private here
```cpp
std::unique_ptr<ThreadPool> _sinker_thread_pool;
^
```
##########
be/test/vec/exec/vtablet_sink_test.cpp:
##########
@@ -345,6 +345,11 @@
_env->_master_info = new TMasterInfo();
_env->_internal_client_cache = new BrpcClientCache<PBackendService_Stub>();
_env->_function_client_cache = new BrpcClientCache<PFunctionService_Stub>();
Review Comment:
warning: '_function_client_cache' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
```cpp
_env->_function_client_cache = new BrpcClientCache<PFunctionService_Stub>();
^
```
**be/src/runtime/exec_env.h:249:** declared private here
```cpp
BrpcClientCache<PFunctionService_Stub>* _function_client_cache = nullptr;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] nextdreamblue closed pull request #18679: (fix)[load] add thread pool for sinker
Posted by "nextdreamblue (via GitHub)" <gi...@apache.org>.
nextdreamblue closed pull request #18679: (fix)[load] add thread pool for sinker
URL: https://github.com/apache/doris/pull/18679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #18679: [fix][load] add thread pool for sinker
Posted by "nextdreamblue (via GitHub)" <gi...@apache.org>.
nextdreamblue commented on PR #18679:
URL: https://github.com/apache/doris/pull/18679#issuecomment-1508248149
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #18679: [fix][load] add thread pool for sinker
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #18679:
URL: https://github.com/apache/doris/pull/18679#issuecomment-1508387951
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.92 seconds
stream load tsv: 420 seconds loaded 74807831229 Bytes, about 169 MB/s
stream load json: 23 seconds loaded 2358488459 Bytes, about 97 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 29 seconds loaded 861443392 Bytes, about 28 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230414115134_clickbench_pr_129185.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org