You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/11/04 01:07:08 UTC
[GitHub] [servicecomb-java-chassis] yanghao605 opened a new pull request, #3453: [SCB-2717] add exception retry for SslHandshakeTimeoutException
yanghao605 opened a new pull request, #3453:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3453
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3453: [SCB-2717] add exception retry for SslHandshakeTimeoutException
Posted by GitBox <gi...@apache.org>.
liubao68 merged PR #3453:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #3453: [SCB-2717] add exception retry for SslHandshakeTimeoutException
Posted by GitBox <gi...@apache.org>.
liubao68 commented on PR #3453:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3453#issuecomment-1305209500
Can you provide more information about why SSL handshake or timeout?
Most of time retry is not a good idea, event retry on another instance. For example, ssl handshake fail for unknow certificate.
Or ssl handshake because two many concurrent SSL handshakes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] yanghao605 commented on pull request #3453: [SCB-2717] add exception retry for SslHandshakeTimeoutException
Posted by GitBox <gi...@apache.org>.
yanghao605 commented on PR #3453:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3453#issuecomment-1305240239
SSL handshake timeout exception caused by Long lasting full gc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] yanghao605 commented on pull request #3453: [SCB-2717] add exception retry for SslHandshakeTimeoutException
Posted by GitBox <gi...@apache.org>.
yanghao605 commented on PR #3453:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3453#issuecomment-1305239196
fullgc耗时过长导致SSL握手超时异常
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #3453: [SCB-2717] add exception retry for SslHandshakeTimeoutException
Posted by GitBox <gi...@apache.org>.
liubao68 commented on PR #3453:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3453#issuecomment-1303056666
Seems retry for timeout exception and handshake exception have more problems than benefit, how do you think so ? @yanghao605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] yanghao605 commented on pull request #3453: [SCB-2717] add exception retry for SslHandshakeTimeoutException
Posted by GitBox <gi...@apache.org>.
yanghao605 commented on PR #3453:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3453#issuecomment-1305170300
ok,by default I will send the retry request to another node
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #3453: [SCB-2717] add exception retry for SslHandshakeTimeoutException
Posted by GitBox <gi...@apache.org>.
liubao68 commented on PR #3453:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3453#issuecomment-1303045166
Issue is not replied. Seems retry for timeout exception and handshake exception will not make things better if retried on same server. But if retry on other instances is a bit useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] yanghao605 commented on pull request #3453: [SCB-2717] add exception retry for SslHandshakeTimeoutException
Posted by GitBox <gi...@apache.org>.
yanghao605 commented on PR #3453:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3453#issuecomment-1305190154
retry for handshaketimeout exception can improve the reliability and reduce the probability of request loss
Maybe, we can apply this issue, then emphasize the retry strategy that user used should be retried on other instances
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org