[GitHub] [hadoop] bharatviswa504 opened a new pull request #943: HDDS-1666. Issue in openKey when allocating block.

[GitBox <gi...@apache.org>]

bharatviswa504 opened a new pull request #943: HDDS-1666. Issue in openKey when allocating block.
URL: https://github.com/apache/hadoop/pull/943
 
 
   We set size as below
   
   final long size = args.getDataSize() >= 0 ?
    args.getDataSize() : scmBlockSize;
    
   
   and create OmKeyInfo with below size set. But when allocating Block for openKey, we use as below.
   
   allocateBlockInKey(keyInfo, args.getDataSize(), currentTime);
   
    
   
   I feel here, we should use size which is set above so that we allocate at least a block when the openKey call happens.
   
   Current Code also works fine, but for readability I believe this should be good.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org