You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2024/04/05 08:10:59 UTC
[PR] Update artifact-handlers.apt [maven]
kwin opened a new pull request, #1466:
URL: https://github.com/apache/maven/pull/1466
Clarify that the extension used outside repositories for pom files usually differs
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #1466:
URL: https://github.com/apache/maven/pull/1466#discussion_r1566385346
##########
maven-core/src/site/apt/artifact-handlers.apt:
##########
@@ -35,7 +35,7 @@ Default Artifact Handlers Reference
*--------------------+---------------+------------+------------+-----------+---------------------+-----------------------+
|| type || classifier || extension || packaging || language || added to classpath || includesDependencies ||
*--------------------+---------------+------------+------------+-----------+---------------------+-----------------------+
-| <<<pom>>> | | <= type> | <= type> | none | | |
+| <<<pom>>> | | <= type>, Note: this differs for POM files outside the repository which usually use <<<xml>>> as filesystem extension. | <= type> | none | | |
Review Comment:
sorry, we had so many discussions that I don't see how to tell.
as said by Tamasz, there is a mix
In addition, such a text will break the table display.
eventually, if you absolutely want to write something, you can add a note at the end of the page that could say something like:
> Dependency type <<\<pom>>> has an extension <<<.pom>>> because POM is stored in repositories as <<<artifactId-version.pom>>>.
> During development, as stored in source control, the POM file is by default named <<<pom.xml>>>: it will be renamed during install/deploy to be later eventually used as a pom dependency
I don't see how useful it is, but it says what you seem to need to say and does not break the dependency type table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1466:
URL: https://github.com/apache/maven/pull/1466#issuecomment-2054138680
The depensency extension is told by type. Deoendency is never "anywhere on disk", it may come from repo only.
You mix few things here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #1466:
URL: https://github.com/apache/maven/pull/1466#discussion_r1564821536
##########
maven-core/src/site/apt/artifact-handlers.apt:
##########
@@ -35,7 +35,7 @@ Default Artifact Handlers Reference
*--------------------+---------------+------------+------------+-----------+---------------------+-----------------------+
|| type || classifier || extension || packaging || language || added to classpath || includesDependencies ||
*--------------------+---------------+------------+------------+-----------+---------------------+-----------------------+
-| <<<pom>>> | | <= type> | <= type> | none | | |
+| <<<pom>>> | | <= type>, Note: this differs for POM files outside the repository which usually use <<<xml>>> as filesystem extension. | <= type> | none | | |
Review Comment:
impossible to understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1466:
URL: https://github.com/apache/maven/pull/1466#issuecomment-2054145589
Recognizing (or assuming) anything about not yet installed/deployed artifact is wrong, as producer may also use anything, like tmp file. It is artifact that you need to inspect, not the backing file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #1466:
URL: https://github.com/apache/maven/pull/1466#issuecomment-2118853443
No consensus here, therefore closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "SDhkjdkbsv (via GitHub)" <gi...@apache.org>.
SDhkjdkbsv commented on PR #1466:
URL: https://github.com/apache/maven/pull/1466#issuecomment-2094687415
You mix few things here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #1466:
URL: https://github.com/apache/maven/pull/1466#discussion_r1566385346
##########
maven-core/src/site/apt/artifact-handlers.apt:
##########
@@ -35,7 +35,7 @@ Default Artifact Handlers Reference
*--------------------+---------------+------------+------------+-----------+---------------------+-----------------------+
|| type || classifier || extension || packaging || language || added to classpath || includesDependencies ||
*--------------------+---------------+------------+------------+-----------+---------------------+-----------------------+
-| <<<pom>>> | | <= type> | <= type> | none | | |
+| <<<pom>>> | | <= type>, Note: this differs for POM files outside the repository which usually use <<<xml>>> as filesystem extension. | <= type> | none | | |
Review Comment:
sorry, we had so many discussions that I don't see how to tell.
as said by Tamasz, there is a mix
In addition, such a text will break the table display.
eventually, if you absolutely want to write something, you can add a note at the end of the page that could say something like:
"Dependency type <<<pom>>> has an extension <<<.pom>>> because POM is stored in repositories as <<<artifactId-version.pom>>>.
During development, as stored in source control, the file is by default named <<<pom.xml>>>"
I don't see how useful it is, but it says what you seem to need to say and does not break the dependency type table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #1466:
URL: https://github.com/apache/maven/pull/1466#issuecomment-2054144475
When you deploy/install artifacts to a repo they come from a file with an extension. Usually this extension is the same as being used inside the repo except for POM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1466:
URL: https://github.com/apache/maven/pull/1466#issuecomment-2042536236
Am unsure is it meaningful at all to speak about artifacts "outside of repository"...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #1466:
URL: https://github.com/apache/maven/pull/1466#issuecomment-2054137233
How are people supposed to know the extension of a dependency? Although admittedly rarely necessary, this is important if you use resolver API directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1466:
URL: https://github.com/apache/maven/pull/1466#issuecomment-2054144860
Wrong, for example signatures are also tmp files, getting their "final form" only at deploy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #1466:
URL: https://github.com/apache/maven/pull/1466#discussion_r1566385346
##########
maven-core/src/site/apt/artifact-handlers.apt:
##########
@@ -35,7 +35,7 @@ Default Artifact Handlers Reference
*--------------------+---------------+------------+------------+-----------+---------------------+-----------------------+
|| type || classifier || extension || packaging || language || added to classpath || includesDependencies ||
*--------------------+---------------+------------+------------+-----------+---------------------+-----------------------+
-| <<<pom>>> | | <= type> | <= type> | none | | |
+| <<<pom>>> | | <= type>, Note: this differs for POM files outside the repository which usually use <<<xml>>> as filesystem extension. | <= type> | none | | |
Review Comment:
sorry, we had so many discussions that I don't see how to tell.
as said by Tamasz, there is a mix
In addition, such a text will break the table display.
eventually, if you absolutely want to write something, you can add a note at the end of the page that could say something like:
> Dependency type <<\<pom>>> has an extension <<<.pom>>> because POM is stored in repositories as <<<artifactId-version.pom>>>.
> During development, as stored in source control, the POM file is by default named <<<pom.xml>>>: it will be renamed during install/deploy to be later used as a pom dependency
I don't see how useful it is, but it says what you seem to need to say and does not break the dependency type table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #1466:
URL: https://github.com/apache/maven/pull/1466#issuecomment-2952855852
source branch deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1466:
URL: https://github.com/apache/maven/pull/1466#issuecomment-2054144734
The depensency extension is told by type. Deoendency is never "anywhere on disk", it may come from repo only.
You mix few things here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on PR #1466:
URL: https://github.com/apache/maven/pull/1466#issuecomment-2054126404
what people need to understand is that artifact handler is for a dependency, not for a file anywhere
and dependencies are in repository (most of the time, I know)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #1466:
URL: https://github.com/apache/maven/pull/1466#issuecomment-2042676447
Well for me extension is mostly connected to files used outside a repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #1466:
URL: https://github.com/apache/maven/pull/1466#discussion_r1564858983
##########
maven-core/src/site/apt/artifact-handlers.apt:
##########
@@ -35,7 +35,7 @@ Default Artifact Handlers Reference
*--------------------+---------------+------------+------------+-----------+---------------------+-----------------------+
|| type || classifier || extension || packaging || language || added to classpath || includesDependencies ||
*--------------------+---------------+------------+------------+-----------+---------------------+-----------------------+
-| <<<pom>>> | | <= type> | <= type> | none | | |
+| <<<pom>>> | | <= type>, Note: this differs for POM files outside the repository which usually use <<<xml>>> as filesystem extension. | <= type> | none | | |
Review Comment:
I would appreciate a more helpful criticism!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #1466:
URL: https://github.com/apache/maven/pull/1466#discussion_r1566385346
##########
maven-core/src/site/apt/artifact-handlers.apt:
##########
@@ -35,7 +35,7 @@ Default Artifact Handlers Reference
*--------------------+---------------+------------+------------+-----------+---------------------+-----------------------+
|| type || classifier || extension || packaging || language || added to classpath || includesDependencies ||
*--------------------+---------------+------------+------------+-----------+---------------------+-----------------------+
-| <<<pom>>> | | <= type> | <= type> | none | | |
+| <<<pom>>> | | <= type>, Note: this differs for POM files outside the repository which usually use <<<xml>>> as filesystem extension. | <= type> | none | | |
Review Comment:
sorry, we had so many discussions that I don't see how to tell.
as said by Tamasz, there is a mix
In addition, such a text will break the table display.
eventually, if you absolutely want to write something, you can add a note at the end of the page that could say something like:
> Dependency type <<\<pom>>> has an extension <<<.pom>>> because POM is stored in repositories as <<<artifactId-version.pom>>>.
> During development, as stored in source control, the file is by default named <<<pom.xml>>>"
I don't see how useful it is, but it says what you seem to need to say and does not break the dependency type table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update artifact-handlers.apt [maven]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin closed pull request #1466: Update artifact-handlers.apt
URL: https://github.com/apache/maven/pull/1466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org