You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry <am...@hortonworks.com> on 2019/02/07 23:59:33 UTC
Review Request 69925: Removed hard-code Use of QualifiedName as
Attribute
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69925/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3048
https://issues.apache.org/jira/browse/ATLAS-3048
Repository: atlas
Description
-------
Using _EntityType.getUniqueAttributes_ to get attributes.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociator.java 628c1cc4b
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociatorTest.java 16074b63c
repository/src/test/resources/json/classification-association/col-entity-def-unique-name.json PRE-CREATION
repository/src/test/resources/json/classification-association/header-PII-no-qualifiedName.json PRE-CREATION
Diff: https://reviews.apache.org/r/69925/diff/1/
Testing
-------
**Unit tests**
Added unit tests.
Thanks,
Ashutosh Mestry
Re: Review Request 69925: Removed hard-code Use of QualifiedName as
Attribute
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69925/#review212676
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Feb. 8, 2019, 10:56 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69925/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2019, 10:56 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3048
> https://issues.apache.org/jira/browse/ATLAS-3048
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Using _EntityType.getUniqueAttributes_ to get attributes.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociator.java 628c1cc4b
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociatorTest.java 16074b63c
> repository/src/test/resources/json/classification-association/col-entity-def-unique-name.json PRE-CREATION
> repository/src/test/resources/json/classification-association/header-PII-no-qualifiedName.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/69925/diff/2/
>
>
> Testing
> -------
>
> **Unit tests**
> Added unit tests.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 69925: Removed hard-code Use of QualifiedName as
Attribute
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69925/#review212675
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Feb. 8, 2019, 6:56 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69925/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2019, 6:56 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3048
> https://issues.apache.org/jira/browse/ATLAS-3048
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Using _EntityType.getUniqueAttributes_ to get attributes.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociator.java 628c1cc4b
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociatorTest.java 16074b63c
> repository/src/test/resources/json/classification-association/col-entity-def-unique-name.json PRE-CREATION
> repository/src/test/resources/json/classification-association/header-PII-no-qualifiedName.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/69925/diff/2/
>
>
> Testing
> -------
>
> **Unit tests**
> Added unit tests.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 69925: Removed hard-code Use of QualifiedName as
Attribute
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69925/
-----------------------------------------------------------
(Updated Feb. 8, 2019, 6:56 p.m.)
Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Updates include: Addressed review comments.
Bugs: ATLAS-3048
https://issues.apache.org/jira/browse/ATLAS-3048
Repository: atlas
Description
-------
Using _EntityType.getUniqueAttributes_ to get attributes.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociator.java 628c1cc4b
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociatorTest.java 16074b63c
repository/src/test/resources/json/classification-association/col-entity-def-unique-name.json PRE-CREATION
repository/src/test/resources/json/classification-association/header-PII-no-qualifiedName.json PRE-CREATION
Diff: https://reviews.apache.org/r/69925/diff/2/
Changes: https://reviews.apache.org/r/69925/diff/1-2/
Testing
-------
**Unit tests**
Added unit tests.
Thanks,
Ashutosh Mestry