You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@daffodil.apache.org by Marshall Miller <ma...@quarksecurity.com> on 2018/07/16 13:57:01 UTC
Pull request #80
Hello,
I submitted pull request 80 to add a layer transform that swaps bytes
within 32 bit words. Unfortunately I failed to follow the contributor
workflow. How would you like me to proceed?
Marshall Miller
Re: Pull request #80
Posted by Steve Lawrence <sl...@apache.org>.
You're now added. You should be able to assign the to yourself now.
Thanks,
- Steve
On 07/16/2018 10:47 AM, Marshall Miller wrote:
> My username is marshallmiller and email is marshall@quarksecurity.com
> <ma...@quarksecurity.com>.
>
> On Mon, Jul 16, 2018 at 10:34 AM, Steve Lawrence <slawrence@apache.org
> <ma...@apache.org>> wrote:
>
> The pull request and testing is the key part of the work flow. What
> you've done looks fine. I think the only thing you skipped is assigning
> the JIRA bug to yourself. If you create a JIRA account and let us know
> the account name we can give you permission to assign the bug.
>
> Regarding the PR, I've made a couple minor comments. Once the comments
> are addressed I'll give it a +1, and we'll need one more +1 from another
> committer before we can merge the change.
>
> - Steve
>
> On 07/16/2018 09:57 AM, Marshall Miller wrote:
> > Hello,
> >
> > I submitted pull request 80 to add a layer transform that swaps bytes
> > within 32 bit words. Unfortunately I failed to follow the contributor
> > workflow. How would you like me to proceed?
> >
> > Marshall Miller
> >
>
>
Re: Pull request #80
Posted by Marshall Miller <ma...@quarksecurity.com>.
My username is marshallmiller and email is marshall@quarksecurity.com.
On Mon, Jul 16, 2018 at 10:34 AM, Steve Lawrence <sl...@apache.org>
wrote:
> The pull request and testing is the key part of the work flow. What
> you've done looks fine. I think the only thing you skipped is assigning
> the JIRA bug to yourself. If you create a JIRA account and let us know
> the account name we can give you permission to assign the bug.
>
> Regarding the PR, I've made a couple minor comments. Once the comments
> are addressed I'll give it a +1, and we'll need one more +1 from another
> committer before we can merge the change.
>
> - Steve
>
> On 07/16/2018 09:57 AM, Marshall Miller wrote:
> > Hello,
> >
> > I submitted pull request 80 to add a layer transform that swaps bytes
> > within 32 bit words. Unfortunately I failed to follow the contributor
> > workflow. How would you like me to proceed?
> >
> > Marshall Miller
> >
>
>
Re: Pull request #80
Posted by Steve Lawrence <sl...@apache.org>.
The pull request and testing is the key part of the work flow. What
you've done looks fine. I think the only thing you skipped is assigning
the JIRA bug to yourself. If you create a JIRA account and let us know
the account name we can give you permission to assign the bug.
Regarding the PR, I've made a couple minor comments. Once the comments
are addressed I'll give it a +1, and we'll need one more +1 from another
committer before we can merge the change.
- Steve
On 07/16/2018 09:57 AM, Marshall Miller wrote:
> Hello,
>
> I submitted pull request 80 to add a layer transform that swaps bytes
> within 32 bit words. Unfortunately I failed to follow the contributor
> workflow. How would you like me to proceed?
>
> Marshall Miller
>