[GitHub] [doris] englefly commented on a diff in pull request #13600: [fix](planner) inlineView alias error

[GitBox <gi...@apache.org>]

englefly commented on code in PR #13600:
URL: https://github.com/apache/doris/pull/13600#discussion_r1003095676


##########
regression-test/suites/correctness/test_pushdown_pred_to_view.groovy:
##########
@@ -54,7 +54,7 @@ The same resolve error occurs when re-analyze v2.
      """
 
      qt_sql """
-         select * from ${viewName} as v1 join ${viewName} as v2 on v1.id=v2.id and v1.id>0;
+         select * from ${viewName} as v1 join ${viewName} as v2 where v1.id=v2.id and v1.id>0;

Review Comment:
   After fix this bug, we found that there is another bug hidden by this bug.
   If we use `on` instead of `where`, the planner push `v1.id=v2.id` down to scan node.
   That is why we modified the regression test temporarily.
   We will fix it latter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org