You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Tom Pasierb (JIRA)" <ji...@codehaus.org> on 2007/09/23 10:42:11 UTC

[jira] Created: (MECLIPSE-326) m2eclipse goal does not respect additionalBuildcommands and additionalProjectnatures defined in pom

m2eclipse goal does not respect additionalBuildcommands and additionalProjectnatures defined in pom
---------------------------------------------------------------------------------------------------

                 Key: MECLIPSE-326
                 URL: http://jira.codehaus.org/browse/MECLIPSE-326
             Project: Maven 2.x Eclipse Plugin
          Issue Type: Bug
    Affects Versions: 2.4
         Environment: win xp, jre/jdk 1.6, maven 2.0.7, maven-eclipse-plugin 2.4
            Reporter: Tom Pasierb
         Attachments: m2eclipseMojoPatch.patch

I have defined additional buildCommand and projectNature in my pom.xml

After running eclipse:m2eclipse on my project, the produced eclipse project descriptors contain neither of the above.

>From what I saw in the source code the m2eclipseMojo uses the setAdditionalBuildcommands and setAdditionalProjectnatures methods not considering that the collections may already contain some entries.

I'm attaching a patch that solves this issue, however I have no experience in developing mojos so I'm not sure if I'm doing it the right way. Should it be acceptable please apply the patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (MECLIPSE-326) m2eclipse goal does not respect additionalBuildcommands and additionalProjectnatures defined in pom

Posted by "Holger Joest (JIRA)" <ji...@codehaus.org>.

     [ http://jira.codehaus.org/browse/MECLIPSE-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Holger Joest updated MECLIPSE-326:
----------------------------------

    Attachment: m2eclipseMojoPatchWithUnitTest.patch

Attached an additional unit test covering this issue.

> m2eclipse goal does not respect additionalBuildcommands and additionalProjectnatures defined in pom
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-326
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-326
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: M2Eclipse support
>    Affects Versions: 2.4
>         Environment: win xp, jre/jdk 1.6, maven 2.0.7, maven-eclipse-plugin 2.4
>            Reporter: Tom Pasierb
>         Attachments: m2eclipseMojoPatch.patch, m2eclipseMojoPatchWithUnitTest.patch
>
>
> I have defined additional buildCommand and projectNature in my pom.xml
> After running eclipse:m2eclipse on my project, the produced eclipse project descriptors contain neither of the above.
> From what I saw in the source code the m2eclipseMojo uses the setAdditionalBuildcommands and setAdditionalProjectnatures methods not considering that the collections may already contain some entries.
> I'm attaching a patch that solves this issue, however I have no experience in developing mojos so I'm not sure if I'm doing it the right way. Should it be acceptable please apply the patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Closed: (MECLIPSE-326) m2eclipse goal does not respect additionalBuildcommands and additionalProjectnatures defined in pom

Posted by "Barrie Treloar (JIRA)" <ji...@codehaus.org>.

     [ http://jira.codehaus.org/browse/MECLIPSE-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Barrie Treloar closed MECLIPSE-326.
-----------------------------------

    Resolution: Fixed

Applied Holger Joest's patch, minor change to test to have an IT suffix so it runs as an IT and not unit test.



> m2eclipse goal does not respect additionalBuildcommands and additionalProjectnatures defined in pom
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-326
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-326
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: M2Eclipse support
>    Affects Versions: 2.4
>         Environment: win xp, jre/jdk 1.6, maven 2.0.7, maven-eclipse-plugin 2.4
>            Reporter: Tom Pasierb
>            Assignee: Barrie Treloar
>             Fix For: 2.6
>
>         Attachments: m2eclipseMojoPatch.patch, m2eclipseMojoPatchWithUnitTest.patch
>
>
> I have defined additional buildCommand and projectNature in my pom.xml
> After running eclipse:m2eclipse on my project, the produced eclipse project descriptors contain neither of the above.
> From what I saw in the source code the m2eclipseMojo uses the setAdditionalBuildcommands and setAdditionalProjectnatures methods not considering that the collections may already contain some entries.
> I'm attaching a patch that solves this issue, however I have no experience in developing mojos so I'm not sure if I'm doing it the right way. Should it be acceptable please apply the patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (MECLIPSE-326) m2eclipse goal does not respect additionalBuildcommands and additionalProjectnatures defined in pom

Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.

     [ http://jira.codehaus.org/browse/MECLIPSE-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arnaud Heritier updated MECLIPSE-326:
-------------------------------------

    Fix Version/s: 2.5.2

> m2eclipse goal does not respect additionalBuildcommands and additionalProjectnatures defined in pom
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-326
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-326
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: M2Eclipse support
>    Affects Versions: 2.4
>         Environment: win xp, jre/jdk 1.6, maven 2.0.7, maven-eclipse-plugin 2.4
>            Reporter: Tom Pasierb
>            Assignee: Arnaud Heritier
>             Fix For: 2.5.2
>
>         Attachments: m2eclipseMojoPatch.patch, m2eclipseMojoPatchWithUnitTest.patch
>
>
> I have defined additional buildCommand and projectNature in my pom.xml
> After running eclipse:m2eclipse on my project, the produced eclipse project descriptors contain neither of the above.
> From what I saw in the source code the m2eclipseMojo uses the setAdditionalBuildcommands and setAdditionalProjectnatures methods not considering that the collections may already contain some entries.
> I'm attaching a patch that solves this issue, however I have no experience in developing mojos so I'm not sure if I'm doing it the right way. Should it be acceptable please apply the patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Work started: (MECLIPSE-326) m2eclipse goal does not respect additionalBuildcommands and additionalProjectnatures defined in pom

Posted by "Barrie Treloar (JIRA)" <ji...@codehaus.org>.

     [ http://jira.codehaus.org/browse/MECLIPSE-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on MECLIPSE-326 started by Barrie Treloar.

> m2eclipse goal does not respect additionalBuildcommands and additionalProjectnatures defined in pom
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-326
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-326
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: M2Eclipse support
>    Affects Versions: 2.4
>         Environment: win xp, jre/jdk 1.6, maven 2.0.7, maven-eclipse-plugin 2.4
>            Reporter: Tom Pasierb
>            Assignee: Barrie Treloar
>             Fix For: 2.6
>
>         Attachments: m2eclipseMojoPatch.patch, m2eclipseMojoPatchWithUnitTest.patch
>
>
> I have defined additional buildCommand and projectNature in my pom.xml
> After running eclipse:m2eclipse on my project, the produced eclipse project descriptors contain neither of the above.
> From what I saw in the source code the m2eclipseMojo uses the setAdditionalBuildcommands and setAdditionalProjectnatures methods not considering that the collections may already contain some entries.
> I'm attaching a patch that solves this issue, however I have no experience in developing mojos so I'm not sure if I'm doing it the right way. Should it be acceptable please apply the patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (MECLIPSE-326) m2eclipse goal does not respect additionalBuildcommands and additionalProjectnatures defined in pom

Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.

     [ http://jira.codehaus.org/browse/MECLIPSE-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arnaud Heritier updated MECLIPSE-326:
-------------------------------------

    Testcase included: yes

> m2eclipse goal does not respect additionalBuildcommands and additionalProjectnatures defined in pom
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-326
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-326
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: M2Eclipse support
>    Affects Versions: 2.4
>         Environment: win xp, jre/jdk 1.6, maven 2.0.7, maven-eclipse-plugin 2.4
>            Reporter: Tom Pasierb
>            Assignee: Arnaud Heritier
>             Fix For: 2.5.2
>
>         Attachments: m2eclipseMojoPatch.patch, m2eclipseMojoPatchWithUnitTest.patch
>
>
> I have defined additional buildCommand and projectNature in my pom.xml
> After running eclipse:m2eclipse on my project, the produced eclipse project descriptors contain neither of the above.
> From what I saw in the source code the m2eclipseMojo uses the setAdditionalBuildcommands and setAdditionalProjectnatures methods not considering that the collections may already contain some entries.
> I'm attaching a patch that solves this issue, however I have no experience in developing mojos so I'm not sure if I'm doing it the right way. Should it be acceptable please apply the patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (MECLIPSE-326) m2eclipse goal does not respect additionalBuildcommands and additionalProjectnatures defined in pom

Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.

     [ http://jira.codehaus.org/browse/MECLIPSE-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arnaud Heritier updated MECLIPSE-326:
-------------------------------------

    Component/s: M2Eclipse support

> m2eclipse goal does not respect additionalBuildcommands and additionalProjectnatures defined in pom
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-326
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-326
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: M2Eclipse support
>    Affects Versions: 2.4
>         Environment: win xp, jre/jdk 1.6, maven 2.0.7, maven-eclipse-plugin 2.4
>            Reporter: Tom Pasierb
>         Attachments: m2eclipseMojoPatch.patch
>
>
> I have defined additional buildCommand and projectNature in my pom.xml
> After running eclipse:m2eclipse on my project, the produced eclipse project descriptors contain neither of the above.
> From what I saw in the source code the m2eclipseMojo uses the setAdditionalBuildcommands and setAdditionalProjectnatures methods not considering that the collections may already contain some entries.
> I'm attaching a patch that solves this issue, however I have no experience in developing mojos so I'm not sure if I'm doing it the right way. Should it be acceptable please apply the patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira