You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by isper3at <gi...@git.apache.org> on 2018/09/14 18:32:25 UTC
[GitHub] incubator-rya pull request #304: RYA-501 Change guava Iterators to Collectio...
GitHub user isper3at opened a pull request:
https://github.com/apache/incubator-rya/pull/304
RYA-501 Change guava Iterators to Collections
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
## Description
>What Changed?
Google changed the Iterators object emptyIterator() visibility.
This can cause versioning issues with anything depending on
a newer version of guava. Using Java's Collections.emptyIterator() instead.
### Tests
>Coverage?
N/A
### Links
[Jira](https://issues.apache.org/jira/browse/RYA-501)
### Checklist
- [ ] Code Review
- [x] Squash Commits
#### People To Reivew
@ejwhite922
@kchilton2
@pujav65
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/isper3at/incubator-rya RYA-501_guavaToJava-4.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #304
----
commit 93c1d89dafc16d4d50bc4581ec6ada311ca494ae
Author: Andrew Smith <sm...@...>
Date: 2018-09-14T16:37:16Z
RYA-501 Change guava Iterators to Collections
Google changed the Iterators object emptyIterator() visibility.
This can cause versioning issues with anything depending on
a newer version of guava. Using Java's Collections.emptyIterator() instead.
----
---
[GitHub] incubator-rya issue #304: RYA-501 Change guava Iterators to Collections
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/304
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/782/
---
[GitHub] incubator-rya pull request #304: RYA-501 Change guava Iterators to Collectio...
Posted by isper3at <gi...@git.apache.org>.
GitHub user isper3at reopened a pull request:
https://github.com/apache/incubator-rya/pull/304
RYA-501 Change guava Iterators to Collections
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
## Description
>What Changed?
Google changed the Iterators object emptyIterator() visibility.
This can cause versioning issues with anything depending on
a newer version of guava. Using Java's Collections.emptyIterator() instead.
### Tests
>Coverage?
N/A
### Links
[Jira](https://issues.apache.org/jira/browse/RYA-501)
### Checklist
- [ ] Code Review
- [x] Squash Commits
#### People To Reivew
@ejwhite922
@kchilton2
@pujav65
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/isper3at/incubator-rya RYA-501_guavaToJava-4.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #304
----
commit 93c1d89dafc16d4d50bc4581ec6ada311ca494ae
Author: Andrew Smith <sm...@...>
Date: 2018-09-14T16:37:16Z
RYA-501 Change guava Iterators to Collections
Google changed the Iterators object emptyIterator() visibility.
This can cause versioning issues with anything depending on
a newer version of guava. Using Java's Collections.emptyIterator() instead.
----
---
[GitHub] incubator-rya issue #304: RYA-501 Change guava Iterators to Collections
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on the issue:
https://github.com/apache/incubator-rya/pull/304
Closing until the #302 is in
---
[GitHub] incubator-rya issue #304: RYA-501 Change guava Iterators to Collections
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/304
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/770/
---