[jira] [Commented] (KAFKA-3691) Confusing logging during metadata update timeout

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-3691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331906#comment-15331906 ] 

ASF GitHub Bot commented on KAFKA-3691:
---------------------------------------

GitHub user granthenke opened a pull request:

    https://github.com/apache/kafka/pull/1509

    KAFKA-3691: Confusing logging during metadata update timeout

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/granthenke/kafka timeout-logging

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1509
    
----
commit 824d9401d3f53e0cdeef371d35433cf811b6225c
Author: Grant Henke <gr...@gmail.com>
Date:   2016-06-14T20:50:49Z

    KAFKA-3691: Confusing logging during metadata update timeout

----


> Confusing logging during metadata update timeout
> ------------------------------------------------
>
>                 Key: KAFKA-3691
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3691
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Grant Henke
>            Assignee: Grant Henke
>
> When the KafkaProducer calls waitOnMetadata it will loop decrementing the remainingWaitMs until it either receives the request metadata or runs out of time. Inside the loop Metadata.awaitUpdate is called with the value in remainingWaitMs. Inside Metadata.awaitUpdate a timeout execption could be thrown using the remainingWaitMs which results in messages like:
> {noformat}
> org.apache.kafka.common.errors.TimeoutException: Failed to update metadata after 3 ms.
> {noformat}
> Perhaps we should catch the exception and log the real maxWaitMs or change the language to make the exception more clear. 
> Note: I still need to investigate further to be sure exactly when this happens, but wanted to log the jira to make sure this is not forgotten. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)