You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/21 20:51:34 UTC

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5043: Allow updating the storage/host tags of service offerings

GabrielBrascher commented on a change in pull request #5043:
URL: https://github.com/apache/cloudstack/pull/5043#discussion_r655695768



##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/UpdateServiceOfferingCmd.java
##########
@@ -71,6 +73,20 @@
             since = "4.13")
     private String zoneIds;
 
+    @Parameter(name = ApiConstants.TAGS,

Review comment:
       Makes sense to create `ApiConstants.STORAGE_TAGS` to differ from generic tags, similar to what we have at the `ApiConstants.HOST_TAGS`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org