You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by hw...@apache.org on 2012/02/27 20:05:48 UTC
svn commit: r1294276 - /subversion/trunk/subversion/libsvn_delta/compat.c
Author: hwright
Date: Mon Feb 27 19:05:47 2012
New Revision: 1294276
URL: http://svn.apache.org/viewvc?rev=1294276&view=rev
Log:
* subversion/libsvn_delta/compat.c
(process_actions): Initialize a variable.
Modified:
subversion/trunk/subversion/libsvn_delta/compat.c
Modified: subversion/trunk/subversion/libsvn_delta/compat.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_delta/compat.c?rev=1294276&r1=1294275&r2=1294276&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_delta/compat.c (original)
+++ subversion/trunk/subversion/libsvn_delta/compat.c Mon Feb 27 19:05:47 2012
@@ -281,7 +281,7 @@ process_actions(void *edit_baton,
svn_boolean_t need_copy = FALSE;
const char *copyfrom_path;
svn_revnum_t copyfrom_rev;
- apr_array_header_t *children;
+ apr_array_header_t *children = NULL;
svn_stream_t *contents = NULL;
svn_checksum_t *checksum = NULL;
svn_revnum_t delete_revnum = SVN_INVALID_REVNUM;
Re: svn commit: r1294276 - /subversion/trunk/subversion/libsvn_delta/compat.c
Posted by Greg Stein <gs...@gmail.com>.
That initialization doesn't need to happen. The only time that
CHILDREN is referenced, it has also been initialized within the code.
Just follow the values for NEED_ADD and KIND.
On Mon, Feb 27, 2012 at 14:05, <hw...@apache.org> wrote:
> Author: hwright
> Date: Mon Feb 27 19:05:47 2012
> New Revision: 1294276
>
> URL: http://svn.apache.org/viewvc?rev=1294276&view=rev
> Log:
> * subversion/libsvn_delta/compat.c
> (process_actions): Initialize a variable.
>
> Modified:
> subversion/trunk/subversion/libsvn_delta/compat.c
>
> Modified: subversion/trunk/subversion/libsvn_delta/compat.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_delta/compat.c?rev=1294276&r1=1294275&r2=1294276&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_delta/compat.c (original)
> +++ subversion/trunk/subversion/libsvn_delta/compat.c Mon Feb 27 19:05:47 2012
> @@ -281,7 +281,7 @@ process_actions(void *edit_baton,
> svn_boolean_t need_copy = FALSE;
> const char *copyfrom_path;
> svn_revnum_t copyfrom_rev;
> - apr_array_header_t *children;
> + apr_array_header_t *children = NULL;
> svn_stream_t *contents = NULL;
> svn_checksum_t *checksum = NULL;
> svn_revnum_t delete_revnum = SVN_INVALID_REVNUM;
>
>