You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/11/24 06:11:42 UTC

[GitHub] [incubator-yunikorn-web] akhilpb001 commented on a change in pull request #49: YUNIKORN-450: Better representation of memory and vcores in yunikorn web

akhilpb001 commented on a change in pull request #49:
URL: https://github.com/apache/incubator-yunikorn-web/pull/49#discussion_r529224832



##########
File path: src/app/utils/common.util.ts
##########
@@ -33,18 +33,18 @@ export class CommonUtil {
     let unit = 'MB';
     let toValue = +value;
 
-    if (toValue / 1024 >= 0.9) {
-      toValue = toValue / 1024;
+    if (toValue / 1000 >= 1) {
+      toValue = toValue / 1000;

Review comment:
       @wilfred-s  @yangwwei  Could you please confirm that we are getting memory in MB (not in MiB) by referencing the shim code?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org