[GitHub] [solr] risdenk commented on a diff in pull request #1568: SOLR-16711: Extract SolrCLI tool implementations into their own package and classes (Take 2)

["risdenk (via GitHub)" <gi...@apache.org>]

risdenk commented on code in PR #1568:
URL: https://github.com/apache/solr/pull/1568#discussion_r1169241778


##########
solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java:
##########
@@ -356,7 +357,7 @@ private boolean deployPackage(
     List<String> previouslyDeployedOnCollections = deployResult.second();
 
     // Verify
-    boolean verifySuccess = true;
+    boolean verifySuccess;
     // Verify that package was successfully deployed
     verifySuccess =

Review Comment:
   Combine these lines?



##########
solr/packaging/test/test_export.bats:
##########
@@ -29,7 +29,7 @@ teardown() {
 }
 
 @test "Check export command" {
-  run solr start -c -Dsolr.modules=sql

Review Comment:
   Ummm why is this removed? This is checking a query so need sql module right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org