You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2016/02/29 04:40:27 UTC
Review Request 43940: AMBARI-15153 : Change Ranger's default value
for LDAP Group Sync Case Conversion properties to "none"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43940/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: AMBARI-15153
https://issues.apache.org/jira/browse/AMBARI-15153
Repository: ambari
Description
-------
Patch contains changes in default value for :
ldapGroupSync.username.caseConversion = "none"
ldapGroupSync.groupname.caseConversion = "none"
Diffs
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 9ad6bbd
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml 5551e51
ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json f90f516
ambari-server/src/test/python/stacks/2.2/configs/default.json f759f49
ambari-server/src/test/python/stacks/2.2/configs/default_custom_path_config.json a70f4c1
ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-default.json a13f50e
ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json d40a804
ambari-server/src/test/python/stacks/2.2/configs/secured.json 2e8fa2f
ambari-server/src/test/python/stacks/2.3/configs/spark_default.json 05e5ed8
ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json f09a3e8
Diff: https://reviews.apache.org/r/43940/diff/
Testing
-------
1) Fresh install of Ranger with Users synced from LDAP (via Ambari).
2) Ambari Upgrade from Ambari-2.2.X to Ambari-2.4.X (retaining defaults to whatever was set in earlier version)
Thanks,
Gautam Borad
Re: Review Request 43940: AMBARI-15153 : Change Ranger's default
value for LDAP Group Sync Case Conversion properties to "none"
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43940/#review122150
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 29, 2016, 3:40 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43940/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 3:40 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15153
> https://issues.apache.org/jira/browse/AMBARI-15153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains changes in default value for :
>
> ldapGroupSync.username.caseConversion = "none"
> ldapGroupSync.groupname.caseConversion = "none"
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 9ad6bbd
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml 5551e51
> ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json f90f516
> ambari-server/src/test/python/stacks/2.2/configs/default.json f759f49
> ambari-server/src/test/python/stacks/2.2/configs/default_custom_path_config.json a70f4c1
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-default.json a13f50e
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json d40a804
> ambari-server/src/test/python/stacks/2.2/configs/secured.json 2e8fa2f
> ambari-server/src/test/python/stacks/2.3/configs/spark_default.json 05e5ed8
> ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json f09a3e8
>
> Diff: https://reviews.apache.org/r/43940/diff/
>
>
> Testing
> -------
>
> 1) Fresh install of Ranger with Users synced from LDAP (via Ambari).
> 2) Ambari Upgrade from Ambari-2.2.X to Ambari-2.4.X (retaining defaults to whatever was set in earlier version)
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 43940: AMBARI-15153 : Change Ranger's default
value for LDAP Group Sync Case Conversion properties to "none"
Posted by Gautam Borad <gb...@gmail.com>.
> On Feb. 29, 2016, 6:11 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml, line 128
> > <https://reviews.apache.org/r/43940/diff/1/?file=1267212#file1267212line128>
> >
> > Does this also need to be set during RU/EU in certain HDP versions?
No Alejandro, we don't need to change value of SYNC_LDAP_USERNAME_CASE_CONVERSION for upgrades.
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43940/#review121273
-----------------------------------------------------------
On Feb. 29, 2016, 3:40 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43940/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 3:40 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15153
> https://issues.apache.org/jira/browse/AMBARI-15153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains changes in default value for :
>
> ldapGroupSync.username.caseConversion = "none"
> ldapGroupSync.groupname.caseConversion = "none"
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 9ad6bbd
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml 5551e51
> ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json f90f516
> ambari-server/src/test/python/stacks/2.2/configs/default.json f759f49
> ambari-server/src/test/python/stacks/2.2/configs/default_custom_path_config.json a70f4c1
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-default.json a13f50e
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json d40a804
> ambari-server/src/test/python/stacks/2.2/configs/secured.json 2e8fa2f
> ambari-server/src/test/python/stacks/2.3/configs/spark_default.json 05e5ed8
> ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json f09a3e8
>
> Diff: https://reviews.apache.org/r/43940/diff/
>
>
> Testing
> -------
>
> 1) Fresh install of Ranger with Users synced from LDAP (via Ambari).
> 2) Ambari Upgrade from Ambari-2.2.X to Ambari-2.4.X (retaining defaults to whatever was set in earlier version)
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 43940: AMBARI-15153 : Change Ranger's default
value for LDAP Group Sync Case Conversion properties to "none"
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43940/#review121273
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml (line 128)
<https://reviews.apache.org/r/43940/#comment182949>
Does this also need to be set during RU/EU in certain HDP versions?
- Alejandro Fernandez
On Feb. 29, 2016, 3:40 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43940/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 3:40 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15153
> https://issues.apache.org/jira/browse/AMBARI-15153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains changes in default value for :
>
> ldapGroupSync.username.caseConversion = "none"
> ldapGroupSync.groupname.caseConversion = "none"
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 9ad6bbd
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml 5551e51
> ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json f90f516
> ambari-server/src/test/python/stacks/2.2/configs/default.json f759f49
> ambari-server/src/test/python/stacks/2.2/configs/default_custom_path_config.json a70f4c1
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-default.json a13f50e
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json d40a804
> ambari-server/src/test/python/stacks/2.2/configs/secured.json 2e8fa2f
> ambari-server/src/test/python/stacks/2.3/configs/spark_default.json 05e5ed8
> ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json f09a3e8
>
> Diff: https://reviews.apache.org/r/43940/diff/
>
>
> Testing
> -------
>
> 1) Fresh install of Ranger with Users synced from LDAP (via Ambari).
> 2) Ambari Upgrade from Ambari-2.2.X to Ambari-2.4.X (retaining defaults to whatever was set in earlier version)
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 43940: AMBARI-15153 : Change Ranger's default
value for LDAP Group Sync Case Conversion properties to "none"
Posted by Gautam Borad <gb...@gmail.com>.
> On Feb. 29, 2016, 6:47 p.m., Jonathan Hurley wrote:
> > Looks fine, except for the question of whether this needs to be done in an upgrade. If existing Ranger installations don't need to have this changed when upgrading stacks, then fine. But it's something we needed answered.
We have verified retention of value during the upgrade.
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43940/#review121284
-----------------------------------------------------------
On Feb. 29, 2016, 3:40 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43940/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 3:40 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15153
> https://issues.apache.org/jira/browse/AMBARI-15153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains changes in default value for :
>
> ldapGroupSync.username.caseConversion = "none"
> ldapGroupSync.groupname.caseConversion = "none"
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 9ad6bbd
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml 5551e51
> ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json f90f516
> ambari-server/src/test/python/stacks/2.2/configs/default.json f759f49
> ambari-server/src/test/python/stacks/2.2/configs/default_custom_path_config.json a70f4c1
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-default.json a13f50e
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json d40a804
> ambari-server/src/test/python/stacks/2.2/configs/secured.json 2e8fa2f
> ambari-server/src/test/python/stacks/2.3/configs/spark_default.json 05e5ed8
> ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json f09a3e8
>
> Diff: https://reviews.apache.org/r/43940/diff/
>
>
> Testing
> -------
>
> 1) Fresh install of Ranger with Users synced from LDAP (via Ambari).
> 2) Ambari Upgrade from Ambari-2.2.X to Ambari-2.4.X (retaining defaults to whatever was set in earlier version)
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 43940: AMBARI-15153 : Change Ranger's default
value for LDAP Group Sync Case Conversion properties to "none"
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43940/#review121284
-----------------------------------------------------------
Ship it!
Looks fine, except for the question of whether this needs to be done in an upgrade. If existing Ranger installations don't need to have this changed when upgrading stacks, then fine. But it's something we needed answered.
- Jonathan Hurley
On Feb. 28, 2016, 10:40 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43940/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2016, 10:40 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15153
> https://issues.apache.org/jira/browse/AMBARI-15153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains changes in default value for :
>
> ldapGroupSync.username.caseConversion = "none"
> ldapGroupSync.groupname.caseConversion = "none"
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 9ad6bbd
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml 5551e51
> ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json f90f516
> ambari-server/src/test/python/stacks/2.2/configs/default.json f759f49
> ambari-server/src/test/python/stacks/2.2/configs/default_custom_path_config.json a70f4c1
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-default.json a13f50e
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json d40a804
> ambari-server/src/test/python/stacks/2.2/configs/secured.json 2e8fa2f
> ambari-server/src/test/python/stacks/2.3/configs/spark_default.json 05e5ed8
> ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json f09a3e8
>
> Diff: https://reviews.apache.org/r/43940/diff/
>
>
> Testing
> -------
>
> 1) Fresh install of Ranger with Users synced from LDAP (via Ambari).
> 2) Ambari Upgrade from Ambari-2.2.X to Ambari-2.4.X (retaining defaults to whatever was set in earlier version)
>
>
> Thanks,
>
> Gautam Borad
>
>