You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "diaohancai (via GitHub)" <gi...@apache.org> on 2023/12/16 08:31:23 UTC
[PR] fix(core): io.grpc.grpc-core dependency conflict [incubator-hugegraph-computer]
diaohancai opened a new pull request, #296:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/296
## Purpose of the PR
- close #295
## Main Changes
Exclude `io.grpc.grpc-core` low version dependency.
## Verifying these changes
<!-- Please pick the proper options below -->
- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
- [ ] Already covered by existing tests, such as *(please modify tests here)*.
- [X] Need tests and can be verified as follows.
Submit any one algorithm job to k8s and job could be successfully executed.
## Does this PR potentially affect the following parts?
- [X] Nope
- [ ] Dependencies (add/update license info) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) -->
- [ ] Modify configurations
- [ ] The public API
- [ ] Other affects (typed here)
## Documentation Status
- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update later -->
- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
- [X] `Doc - No Need` <!-- Your PR changes don't impact/need docs -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(core): io.grpc.grpc-core dependency conflict [incubator-hugegraph-computer]
Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme merged PR #296:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(core): io.grpc.grpc-core dependency conflict [incubator-hugegraph-computer]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #296:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/296#issuecomment-1858787954
## [Codecov](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/296?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `29 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`e0b484a`)](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/commit/e0b484a65e2244ec49ef8bbc14185acd99dbc436?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 85.03% compared to head [(`ba3d44c`)](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/296?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 84.97%.
> Report is 3 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/hugegraph/computer/core/bsp/EtcdClient.java](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tcHV0ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2NvbXB1dGVyL2NvcmUvYnNwL0V0Y2RDbGllbnQuamF2YQ==) | 52.38% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hugegraph/computer/core/worker/WorkerService.java](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tcHV0ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2NvbXB1dGVyL2NvcmUvd29ya2VyL1dvcmtlclNlcnZpY2UuamF2YQ==) | 85.93% | [8 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hugegraph/computer/core/master/MasterService.java](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tcHV0ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2NvbXB1dGVyL2NvcmUvbWFzdGVyL01hc3RlclNlcnZpY2UuamF2YQ==) | 50.00% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...raph/computer/k8s/operator/OperatorEntrypoint.java](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tcHV0ZXItazhzLW9wZXJhdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWdlZ3JhcGgvY29tcHV0ZXIvazhzL29wZXJhdG9yL09wZXJhdG9yRW50cnlwb2ludC5qYXZh) | 81.81% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...h/computer/core/network/session/ClientSession.java](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tcHV0ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2NvbXB1dGVyL2NvcmUvbmV0d29yay9zZXNzaW9uL0NsaWVudFNlc3Npb24uamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #296 +/- ##
============================================
- Coverage 85.03% 84.97% -0.06%
- Complexity 3296 3302 +6
============================================
Files 349 349
Lines 12485 12500 +15
Branches 1130 1132 +2
============================================
+ Hits 10616 10622 +6
- Misses 1329 1339 +10
+ Partials 540 539 -1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/296?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org