You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/04 10:49:09 UTC

[GitHub] [beam] EDjur edited a comment on issue #11040: [BEAM-9305] Allow value provider query strings in _CustomBigQuerySource

EDjur edited a comment on issue #11040: [BEAM-9305] Allow value provider query strings in _CustomBigQuerySource
URL: https://github.com/apache/beam/pull/11040#issuecomment-594450634
 
 
   Since `estimate_size` is called before `split` and the uses `self.query`, I realised the value provider evaluation actually needs to take place before `split` is called. Does this make sense @pabloem ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services