You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/07/07 13:58:06 UTC

[GitHub] [orc] belugabehr commented on a change in pull request #736: ORC-831: Do Not Copy String When Flushing Dictionary

belugabehr commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665397854



##########
File path: java/core/src/java/org/apache/orc/impl/Dictionary.java
##########
@@ -47,6 +47,15 @@
    */
   void getText(Text result, int position);
 
+  /**
+   * Given the position index, write the original string, before being encoded,
+   * to the OutputStream.

Review comment:
       @pgaref Thanks for checking this out too.
   
   Since this is an API, I don't think there should be that level of details/constraints in regards to the implementations.  Anyone implementing this API can choose to do what they want. :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org