You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/20 17:41:26 UTC
[GitHub] [incubator-druid] leventov commented on issue #7061: Fix
concurrency in old Druid classes
leventov commented on issue #7061: Fix concurrency in old Druid classes
URL: https://github.com/apache/incubator-druid/issues/7061#issuecomment-494083865
@umasankar-yedida great! You can take any class that has signs of concurrency (`synchronized` keyword, use of `ConcurrentHashMap`, ExecutorServices, Threads, etc.) and review it according to the [checklist](https://github.com/code-review-checklists/java-concurrency). If the class doesn't have bugs, at least it lacks comments and concurrent access documentation: see items in the [Documentation](https://github.com/code-review-checklists/java-concurrency#documentation) section of the checklist. So literally every old class with concurrency in Druid can be improved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org