You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "matrei (via GitHub)" <gi...@apache.org> on 2026/04/17 06:52:41 UTC
[PR] Update `formActionSubmit` documentation [grails-core]
matrei opened a new pull request, #15582:
URL: https://github.com/apache/grails-core/pull/15582
This pull request updates the documentation and code comments for the `formActionSubmit` tag to clarify the meaning and usage of its attributes, especially regarding the distinction between the DOM `id` and the `id` used in generated URLs. The changes make the attribute descriptions more precise and user-friendly, and introduce documentation for the new `disabled` attribute.
Documentation improvements:
* Clarified the description of the `value` attribute as the label shown on the submit button, and the `id` attribute as the DOM id of the rendered input element in both the user documentation (`formActionSubmit.adoc`) and GroovyDoc comments (`FormTagLib.groovy`). [[1]](diffhunk://#diff-476e02bef89135e6b187a2b66413103a5ca66d331886810ff705bd758564b03cL64-R75) [[2]](diffhunk://#diff-2a773759962f91a6e2ca2afe88468e03650c35d5af0275a0fcc847c87d52474dL560-R580)
* Added documentation for the `disabled` attribute, explaining that it disables the button when true. [[1]](diffhunk://#diff-476e02bef89135e6b187a2b66413103a5ca66d331886810ff705bd758564b03cL64-R75) [[2]](diffhunk://#diff-2a773759962f91a6e2ca2afe88468e03650c35d5af0275a0fcc847c87d52474dL560-R580)
* Clarified that the `url` attribute should be used to provide an `id` for the generated link, since the top-level `id` attribute is reserved for the DOM element. [[1]](diffhunk://#diff-476e02bef89135e6b187a2b66413103a5ca66d331886810ff705bd758564b03cL64-R75) [[2]](diffhunk://#diff-2a773759962f91a6e2ca2afe88468e03650c35d5af0275a0fcc847c87d52474dL560-R580)
* Improved consistency and readability of attribute descriptions, including punctuation and terminology (e.g., "generated link" instead of "link"). [[1]](diffhunk://#diff-476e02bef89135e6b187a2b66413103a5ca66d331886810ff705bd758564b03cL64-R75) [[2]](diffhunk://#diff-2a773759962f91a6e2ca2afe88468e03650c35d5af0275a0fcc847c87d52474dL560-R580)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update `formActionSubmit` documentation [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #15582:
URL: https://github.com/apache/grails-core/pull/15582#issuecomment-4319659877
Given that this is documentation, I'm going to go ahead and merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update `formActionSubmit` documentation [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15582:
URL: https://github.com/apache/grails-core/pull/15582#issuecomment-4266293937
## ✅ All tests passed ✅
🏷️ Commit: c81d16058fa8a002d9d252e342aed6cc21c68978
▶️ Tests: 40174 executed
⚪️ Checks: 31/31 completed
---
_Learn more about TestLens at [testlens.app](https://testlens.app)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update `formActionSubmit` documentation [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty merged PR #15582:
URL: https://github.com/apache/grails-core/pull/15582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org