[GitHub] [spark] viirya commented on a change in pull request #35850: [SPARK-38529][SQL] Fix a bug that GeneratorNestedColumnAliasing is incorrectly applied to non-Explode generators.

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #35850:
URL: https://github.com/apache/spark/pull/35850#discussion_r827173664



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##########
@@ -348,6 +382,11 @@ object GeneratorNestedColumnAliasing {
         case _ =>
       }
 
+      g.generator match {
+        case _: ExplodeBase =>
+        case _ => return Some(pushedThrough)
+      }

Review comment:
       I think you can just remove `Inline` from `canPruneGenerator`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org