You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mattyb149 <gi...@git.apache.org> on 2017/11/02 15:38:49 UTC
[GitHub] nifi pull request #2246: NIFI-4559: Add non-zero status relationship to Exec...
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2246
NIFI-4559: Add non-zero status relationship to ExecuteStreamCommand
Sorry about the whitespace changes, I must have slightly different (but still compliant) formatting settings in my IDE.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-4559
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2246.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2246
----
----
---
[GitHub] nifi issue #2246: NIFI-4559: Add non-zero status relationship to ExecuteStre...
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2246
@mattyb149 As mentioned, I tried this out and got it to work. So I see no reason it cannot be merged.
---
[GitHub] nifi pull request #2246: NIFI-4559: Add non-zero status relationship to Exec...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2246
---
[GitHub] nifi pull request #2246: NIFI-4559: Add non-zero status relationship to Exec...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2246#discussion_r148575679
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java ---
@@ -222,6 +231,16 @@ public ValidationResult validate(String subject, String input, ValidationContext
.defaultValue(";")
.build();
+ static final PropertyDescriptor PENALIZE_NONZERO_STATUS = new PropertyDescriptor.Builder()
--- End diff --
Good point. That property is only to retain current behavior. If they leave the defaults, then once they upgrade, their "failed" flow files will now start to be penalized. That may be acceptable since the user will need to route or terminate that new relationship anyway, so I could add to the doc that flow files routed to that relationship will be penalized, which should imply that they might need to change the Penalty Duration setting?
---
[GitHub] nifi issue #2246: NIFI-4559: Add non-zero status relationship to ExecuteStre...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2246
@MikeThomsen Thank you for your review! I think I tested it fairly well also, so with your +1 I can merge this in.
---
[GitHub] nifi pull request #2246: NIFI-4559: Add non-zero status relationship to Exec...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2246#discussion_r148575125
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java ---
@@ -222,6 +231,16 @@ public ValidationResult validate(String subject, String input, ValidationContext
.defaultValue(";")
.build();
+ static final PropertyDescriptor PENALIZE_NONZERO_STATUS = new PropertyDescriptor.Builder()
--- End diff --
I wonder if this is necessary? The processor doesn't currently penalize anything. I think it may make sense to always penalize when sending to the new relationship and the user has the ability to just set Penalty Duration to "0 sec" if they don't want to penalize.
---