You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Martin Makundi <ma...@koodaripalvelut.com> on 2010/11/09 10:27:17 UTC
Wicket ajax-enabled enclosures
Hi!
Does <wicket:enclosure> have capability to "setOutputMarkupPlaceholderTag" ?
What I mean is that when I have:
<wicket:enclosure child="optional-field">
<tr>
<td>optional content</td>
<td><input type="text" wicket:id="optional-field"/></td>
</tr>
</wicket>
If I set it invisible via ajax I cannot set it visible again.
Instead, is there a way to do something like:
<tr wicket:enclosure="child:optional-field">
<td>optional content</td>
<td><input type="text" wicket:id="optional-field"/></td>
</tr>
So that it would automatically handle visible/hidden
"setOutputMarkupPlaceholderTag" flavour so that I can repaint a hidden
element via ajax?
@See http://jawher.wordpress.com/2009/09/17/wicket-enclosures-and-ajax-no-no/
**
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Wicket ajax-enabled enclosures
Posted by Martin Makundi <ma...@koodaripalvelut.com>.
Hi!
> 1) Generate a patch with a Quickstart that demonstrates the proposed functionality
> 2) Attach it to a Jira issue
>
> First impressions matter a lot, so if you post the Jira without the code, it's going to get ignored, possibly even after you post the code, which would waste your time.
>
> Why not get yourself organized and present yourself professionally? You sound eager and capable, show people your best!
I'm just asking for help (keeping it professional).
I have looked at the Enclosure.java and I would like to hear from
somebody with insight how to go at it, what to look for etc. beforing
going at it full speed.
**
Martin
> Brian
>
> On Nov 9, 2010, at 10:39 AM, Martin Makundi wrote:
>
>> Hi!
>>
>> Has this been attempted before? Would it be a good idea to go at it?
>> Sure would help removing some boilerplate webmarkupcontainer code.
>> Existing jira issue for this?
>>
>> **
>> Martin
>>
>> 2010/11/9 Martin Makundi <ma...@koodaripalvelut.com>:
>>> Hi!
>>>
>>> Does <wicket:enclosure> have capability to "setOutputMarkupPlaceholderTag" ?
>>>
>>> What I mean is that when I have:
>>> <wicket:enclosure child="optional-field">
>>> <tr>
>>> <td>optional content</td>
>>> <td><input type="text" wicket:id="optional-field"/></td>
>>> </tr>
>>> </wicket>
>>>
>>> If I set it invisible via ajax I cannot set it visible again.
>>>
>>> Instead, is there a way to do something like:
>>>
>>>
>>> <tr wicket:enclosure="child:optional-field">
>>> <td>optional content</td>
>>> <td><input type="text" wicket:id="optional-field"/></td>
>>> </tr>
>>>
>>> So that it would automatically handle visible/hidden
>>> "setOutputMarkupPlaceholderTag" flavour so that I can repaint a hidden
>>> element via ajax?
>>>
>>> @See http://jawher.wordpress.com/2009/09/17/wicket-enclosures-and-ajax-no-no/
>>>
>>>
>>> **
>>> Martin
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Wicket ajax-enabled enclosures
Posted by Brian Topping <to...@codehaus.org>.
It's the same pattern as the last suggestion you had:
1) Generate a patch with a Quickstart that demonstrates the proposed functionality
2) Attach it to a Jira issue
First impressions matter a lot, so if you post the Jira without the code, it's going to get ignored, possibly even after you post the code, which would waste your time.
Why not get yourself organized and present yourself professionally? You sound eager and capable, show people your best!
Brian
On Nov 9, 2010, at 10:39 AM, Martin Makundi wrote:
> Hi!
>
> Has this been attempted before? Would it be a good idea to go at it?
> Sure would help removing some boilerplate webmarkupcontainer code.
> Existing jira issue for this?
>
> **
> Martin
>
> 2010/11/9 Martin Makundi <ma...@koodaripalvelut.com>:
>> Hi!
>>
>> Does <wicket:enclosure> have capability to "setOutputMarkupPlaceholderTag" ?
>>
>> What I mean is that when I have:
>> <wicket:enclosure child="optional-field">
>> <tr>
>> <td>optional content</td>
>> <td><input type="text" wicket:id="optional-field"/></td>
>> </tr>
>> </wicket>
>>
>> If I set it invisible via ajax I cannot set it visible again.
>>
>> Instead, is there a way to do something like:
>>
>>
>> <tr wicket:enclosure="child:optional-field">
>> <td>optional content</td>
>> <td><input type="text" wicket:id="optional-field"/></td>
>> </tr>
>>
>> So that it would automatically handle visible/hidden
>> "setOutputMarkupPlaceholderTag" flavour so that I can repaint a hidden
>> element via ajax?
>>
>> @See http://jawher.wordpress.com/2009/09/17/wicket-enclosures-and-ajax-no-no/
>>
>>
>> **
>> Martin
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Wicket ajax-enabled enclosures
Posted by Martin Makundi <ma...@koodaripalvelut.com>.
It is pretty similar syntax to wicket:message. any pointers how to
implement it or if there would be some pitfalls? I understand
transarent markup containers are somewhat tricky?
**
Martin
2010/11/9 Martin Grigorov <mg...@apache.org>:
> On Tue, Nov 9, 2010 at 4:39 PM, Martin Makundi <
> martin.makundi@koodaripalvelut.com> wrote:
>
>> Hi!
>>
>> Has this been attempted before? Would it be a good idea to go at it?
>> Sure would help removing some boilerplate webmarkupcontainer code.
>> Existing jira issue for this?
>>
> At least I haven't seen one.
>
>>
>> **
>> Martin
>>
>> 2010/11/9 Martin Makundi <ma...@koodaripalvelut.com>:
>> > Hi!
>> >
>> > Does <wicket:enclosure> have capability to
>> "setOutputMarkupPlaceholderTag" ?
>> >
>> > What I mean is that when I have:
>> > <wicket:enclosure child="optional-field">
>> > <tr>
>> > <td>optional content</td>
>> > <td><input type="text" wicket:id="optional-field"/></td>
>> > </tr>
>> > </wicket>
>> >
>> > If I set it invisible via ajax I cannot set it visible again.
>> >
>> > Instead, is there a way to do something like:
>> >
>> >
>> > <tr wicket:enclosure="child:optional-field">
>> > <td>optional content</td>
>> > <td><input type="text" wicket:id="optional-field"/></td>
>> > </tr>
>> >
>> > So that it would automatically handle visible/hidden
>> > "setOutputMarkupPlaceholderTag" flavour so that I can repaint a hidden
>> > element via ajax?
>> >
>> > @See
>> http://jawher.wordpress.com/2009/09/17/wicket-enclosures-and-ajax-no-no/
>> >
>> >
>> > **
>> > Martin
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Wicket ajax-enabled enclosures
Posted by Martin Grigorov <mg...@apache.org>.
On Tue, Nov 9, 2010 at 4:39 PM, Martin Makundi <
martin.makundi@koodaripalvelut.com> wrote:
> Hi!
>
> Has this been attempted before? Would it be a good idea to go at it?
> Sure would help removing some boilerplate webmarkupcontainer code.
> Existing jira issue for this?
>
At least I haven't seen one.
>
> **
> Martin
>
> 2010/11/9 Martin Makundi <ma...@koodaripalvelut.com>:
> > Hi!
> >
> > Does <wicket:enclosure> have capability to
> "setOutputMarkupPlaceholderTag" ?
> >
> > What I mean is that when I have:
> > <wicket:enclosure child="optional-field">
> > <tr>
> > <td>optional content</td>
> > <td><input type="text" wicket:id="optional-field"/></td>
> > </tr>
> > </wicket>
> >
> > If I set it invisible via ajax I cannot set it visible again.
> >
> > Instead, is there a way to do something like:
> >
> >
> > <tr wicket:enclosure="child:optional-field">
> > <td>optional content</td>
> > <td><input type="text" wicket:id="optional-field"/></td>
> > </tr>
> >
> > So that it would automatically handle visible/hidden
> > "setOutputMarkupPlaceholderTag" flavour so that I can repaint a hidden
> > element via ajax?
> >
> > @See
> http://jawher.wordpress.com/2009/09/17/wicket-enclosures-and-ajax-no-no/
> >
> >
> > **
> > Martin
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
Re: Wicket ajax-enabled enclosures
Posted by Martin Makundi <ma...@koodaripalvelut.com>.
Hi!
Has this been attempted before? Would it be a good idea to go at it?
Sure would help removing some boilerplate webmarkupcontainer code.
Existing jira issue for this?
**
Martin
2010/11/9 Martin Makundi <ma...@koodaripalvelut.com>:
> Hi!
>
> Does <wicket:enclosure> have capability to "setOutputMarkupPlaceholderTag" ?
>
> What I mean is that when I have:
> <wicket:enclosure child="optional-field">
> <tr>
> <td>optional content</td>
> <td><input type="text" wicket:id="optional-field"/></td>
> </tr>
> </wicket>
>
> If I set it invisible via ajax I cannot set it visible again.
>
> Instead, is there a way to do something like:
>
>
> <tr wicket:enclosure="child:optional-field">
> <td>optional content</td>
> <td><input type="text" wicket:id="optional-field"/></td>
> </tr>
>
> So that it would automatically handle visible/hidden
> "setOutputMarkupPlaceholderTag" flavour so that I can repaint a hidden
> element via ajax?
>
> @See http://jawher.wordpress.com/2009/09/17/wicket-enclosures-and-ajax-no-no/
>
>
> **
> Martin
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Wicket ajax-enabled enclosures
Posted by Martin Makundi <ma...@koodaripalvelut.com>.
> As soon as we have enough confidence it is stable enough for the most users.
> And this will happen as soon as you (the users start to upgrade and report
> problems).
> As you know we have limited resources and supporting more branches is hard
> for us. That's why I prefer to reduce the work on the older branch and keep our
> focus and energy in the newer (and better).
Well, the problem is same elsewhere. But it is a chicken-and-egg
problem. The more we spend time on working with 1.4 the less likely we
are to move onto 1.5 which is more fragile.
As soon as 1.4 works like a ferrari, we might have time to start
working with 1.5 in parallel - as you said, it will need to "report
problems" for quite some time in beginning. Because we cannot demote
the user experience/quality our customers perceive, we must keep
running 1.4 until 1.5 is solid and we have fully migrated.
So 1.5 is going to be a pet project for very long time for us. Only
when we make new products we can afford to start from scratch with 1.5
and deal with its shortcomings and fix it if possible as they came
along.
Maybe 1.5 and 1.4 commiter teams should be separated so that each can
focus completely on what they are doing without bias?
**
Martin
>
>
>> I expect it to be another year until
>> we have ported to 1.5. Or maybe if we hire some summermonkeys to do
>> that for us ... anyways, I think 1.4 is quite viable still for
>> existing applications so I believe it is worth the effor specifically
>> for "major improvements" and bugfixes.
>>
>
>
>>
>> **
>> Martin
>>
>> >>
>> >> 2011/2/6 Martin Makundi <ma...@koodaripalvelut.com>:
>> >> > Hi Martin!
>> >> >
>> >> > We have provided a patch
>> >> https://issues.apache.org/jira/browse/WICKET-3422
>> >> >
>> >> > Is it ok or do you have any further suggestions?
>> >> >
>> >> > **
>> >> > Martin
>> >> >
>> >> > 2010/11/11 Jeremy Thomerson <je...@wickettraining.com>:
>> >> >>> Hi!
>> >> >>>
>> >> >> Provide a patch on JIRA and we'll review it.
>> >> >>
>> >> >> --
>> >> >> Jeremy Thomerson
>> >> >> http://wickettraining.com
>> >> >> *Need a CMS for Wicket? Use Brix! http://brixcms.org*
>> >> >>
>> >> >
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> >> For additional commands, e-mail: users-help@wicket.apache.org
>> >>
>> >>
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Wicket ajax-enabled enclosures
Posted by Martin Grigorov <mg...@apache.org>.
On Wed, Feb 16, 2011 at 5:29 PM, Martin Makundi <
martin.makundi@koodaripalvelut.com> wrote:
> > I took a look at it but it is quite a big changelist ...
> > I think our expert in the area - Juergen - have to take a look before
> > committing it.
> >
> > I also think such bigger new features should go in 1.5 only (disclaimer:
> I
> > don't use 1.4 these days)
>
> It is not so big... but I am keen to hear Juergen's opinnion, however.
>
> When will 1.5 be out of RC phase?
As soon as we have enough confidence it is stable enough for the most users.
And this will happen as soon as you (the users start to upgrade and report
problems).
> I expect it to be another year until
> we have ported to 1.5. Or maybe if we hire some summermonkeys to do
> that for us ... anyways, I think 1.4 is quite viable still for
> existing applications so I believe it is worth the effor specifically
> for "major improvements" and bugfixes.
>
As you know we have limited resources and supporting more branches is hard
for us.
That's why I prefer to reduce the work on the older branch and keep our
focus and energy in the newer (and better).
>
> **
> Martin
>
> >>
> >> 2011/2/6 Martin Makundi <ma...@koodaripalvelut.com>:
> >> > Hi Martin!
> >> >
> >> > We have provided a patch
> >> https://issues.apache.org/jira/browse/WICKET-3422
> >> >
> >> > Is it ok or do you have any further suggestions?
> >> >
> >> > **
> >> > Martin
> >> >
> >> > 2010/11/11 Jeremy Thomerson <je...@wickettraining.com>:
> >> >>> Hi!
> >> >>>
> >> >> Provide a patch on JIRA and we'll review it.
> >> >>
> >> >> --
> >> >> Jeremy Thomerson
> >> >> http://wickettraining.com
> >> >> *Need a CMS for Wicket? Use Brix! http://brixcms.org*
> >> >>
> >> >
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> >> For additional commands, e-mail: users-help@wicket.apache.org
> >>
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
Re: Wicket ajax-enabled enclosures
Posted by Martin Makundi <ma...@koodaripalvelut.com>.
> I took a look at it but it is quite a big changelist ...
> I think our expert in the area - Juergen - have to take a look before
> committing it.
>
> I also think such bigger new features should go in 1.5 only (disclaimer: I
> don't use 1.4 these days)
It is not so big... but I am keen to hear Juergen's opinnion, however.
When will 1.5 be out of RC phase? I expect it to be another year until
we have ported to 1.5. Or maybe if we hire some summermonkeys to do
that for us ... anyways, I think 1.4 is quite viable still for
existing applications so I believe it is worth the effor specifically
for "major improvements" and bugfixes.
**
Martin
>>
>> 2011/2/6 Martin Makundi <ma...@koodaripalvelut.com>:
>> > Hi Martin!
>> >
>> > We have provided a patch
>> https://issues.apache.org/jira/browse/WICKET-3422
>> >
>> > Is it ok or do you have any further suggestions?
>> >
>> > **
>> > Martin
>> >
>> > 2010/11/11 Jeremy Thomerson <je...@wickettraining.com>:
>> >>> Hi!
>> >>>
>> >> Provide a patch on JIRA and we'll review it.
>> >>
>> >> --
>> >> Jeremy Thomerson
>> >> http://wickettraining.com
>> >> *Need a CMS for Wicket? Use Brix! http://brixcms.org*
>> >>
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Wicket ajax-enabled enclosures
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
On Wed, Feb 16, 2011 at 5:17 PM, Martin Makundi <
martin.makundi@koodaripalvelut.com> wrote:
> Hi!
>
> Any thoughts about getting this into next release? It is fully backed
> with tests etc. so it should be easy to commit. We could provide
> necessary wiki update also.
>
I took a look at it but it is quite a big changelist ...
I think our expert in the area - Juergen - have to take a look before
committing it.
I also think such bigger new features should go in 1.5 only (disclaimer: I
don't use 1.4 these days)
>
> **
> Martin
>
> 2011/2/6 Martin Makundi <ma...@koodaripalvelut.com>:
> > Hi Martin!
> >
> > We have provided a patch
> https://issues.apache.org/jira/browse/WICKET-3422
> >
> > Is it ok or do you have any further suggestions?
> >
> > **
> > Martin
> >
> > 2010/11/11 Jeremy Thomerson <je...@wickettraining.com>:
> >>> Hi!
> >>>
> >> Provide a patch on JIRA and we'll review it.
> >>
> >> --
> >> Jeremy Thomerson
> >> http://wickettraining.com
> >> *Need a CMS for Wicket? Use Brix! http://brixcms.org*
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
Re: Wicket ajax-enabled enclosures
Posted by Martin Makundi <ma...@koodaripalvelut.com>.
Hi!
Any thoughts about getting this into next release? It is fully backed
with tests etc. so it should be easy to commit. We could provide
necessary wiki update also.
**
Martin
2011/2/6 Martin Makundi <ma...@koodaripalvelut.com>:
> Hi Martin!
>
> We have provided a patch https://issues.apache.org/jira/browse/WICKET-3422
>
> Is it ok or do you have any further suggestions?
>
> **
> Martin
>
> 2010/11/11 Jeremy Thomerson <je...@wickettraining.com>:
>>> Hi!
>>>
>> Provide a patch on JIRA and we'll review it.
>>
>> --
>> Jeremy Thomerson
>> http://wickettraining.com
>> *Need a CMS for Wicket? Use Brix! http://brixcms.org*
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Wicket ajax-enabled enclosures
Posted by Jeremy Thomerson <je...@wickettraining.com>.
On Tue, Nov 9, 2010 at 4:27 AM, Martin Makundi <
martin.makundi@koodaripalvelut.com> wrote:
> Hi!
>
> Does <wicket:enclosure> have capability to "setOutputMarkupPlaceholderTag"
> ?
>
> What I mean is that when I have:
> <wicket:enclosure child="optional-field">
> <tr>
> <td>optional content</td>
> <td><input type="text" wicket:id="optional-field"/></td>
> </tr>
> </wicket>
>
> If I set it invisible via ajax I cannot set it visible again.
>
> Instead, is there a way to do something like:
>
>
> <tr wicket:enclosure="child:optional-field">
> <td>optional content</td>
> <td><input type="text" wicket:id="optional-field"/></td>
> </tr>
>
> So that it would automatically handle visible/hidden
> "setOutputMarkupPlaceholderTag" flavour so that I can repaint a hidden
> element via ajax?
>
Not currently. wicket:enclosure is an auto-added component, which means it
goes away after the rendering cycle. Since you didn't add it in your code,
you can't access it to call setOutputMarkupPlaceholderTag on it.
You could probably extend it so that it adds a behavior to the child
component that changes the ajax markup ID of the component. See
IAjaxRegionMarkupIdProvider
Provide a patch on JIRA and we'll review it.
--
Jeremy Thomerson
http://wickettraining.com
*Need a CMS for Wicket? Use Brix! http://brixcms.org*